forked from pool/glibc
104 lines
2.8 KiB
Diff
104 lines
2.8 KiB
Diff
|
* sysdeps/unix/sysv/linux/check_pf.c (make_request): Add out_fail2
|
||
|
label to be used after in6ailist is initialized.
|
||
|
|
||
|
[BZ #16002]
|
||
|
* sysdeps/unix/sysv/linux/check_pf.c (make_request): Use
|
||
|
alloca_account and account alloca use for struct in6ailist.
|
||
|
|
||
|
Index: glibc-2.19/sysdeps/unix/sysv/linux/check_pf.c
|
||
|
===================================================================
|
||
|
--- glibc-2.19.orig/sysdeps/unix/sysv/linux/check_pf.c
|
||
|
+++ glibc-2.19/sysdeps/unix/sysv/linux/check_pf.c
|
||
|
@@ -139,9 +139,10 @@ make_request (int fd, pid_t pid)
|
||
|
#endif
|
||
|
bool use_malloc = false;
|
||
|
char *buf;
|
||
|
+ size_t alloca_used = 0;
|
||
|
|
||
|
if (__libc_use_alloca (buf_size))
|
||
|
- buf = alloca (buf_size);
|
||
|
+ buf = alloca_account (buf_size, alloca_used);
|
||
|
else
|
||
|
{
|
||
|
buf = malloc (buf_size);
|
||
|
@@ -163,6 +164,7 @@ make_request (int fd, pid_t pid)
|
||
|
{
|
||
|
struct in6addrinfo info;
|
||
|
struct in6ailist *next;
|
||
|
+ bool use_malloc;
|
||
|
} *in6ailist = NULL;
|
||
|
size_t in6ailistlen = 0;
|
||
|
bool seen_ipv4 = false;
|
||
|
@@ -180,10 +182,10 @@ make_request (int fd, pid_t pid)
|
||
|
|
||
|
ssize_t read_len = TEMP_FAILURE_RETRY (__recvmsg (fd, &msg, 0));
|
||
|
if (read_len < 0)
|
||
|
- goto out_fail;
|
||
|
+ goto out_fail2;
|
||
|
|
||
|
if (msg.msg_flags & MSG_TRUNC)
|
||
|
- goto out_fail;
|
||
|
+ goto out_fail2;
|
||
|
|
||
|
struct nlmsghdr *nlmh;
|
||
|
for (nlmh = (struct nlmsghdr *) buf;
|
||
|
@@ -239,7 +241,19 @@ make_request (int fd, pid_t pid)
|
||
|
}
|
||
|
}
|
||
|
|
||
|
- struct in6ailist *newp = alloca (sizeof (*newp));
|
||
|
+ struct in6ailist *newp;
|
||
|
+ if (__libc_use_alloca (alloca_used + sizeof (*newp)))
|
||
|
+ {
|
||
|
+ newp = alloca_account (sizeof (*newp), alloca_used);
|
||
|
+ newp->use_malloc = false;
|
||
|
+ }
|
||
|
+ else
|
||
|
+ {
|
||
|
+ newp = malloc (sizeof (*newp));
|
||
|
+ if (newp == NULL)
|
||
|
+ goto out_fail2;
|
||
|
+ newp->use_malloc = true;
|
||
|
+ }
|
||
|
newp->info.flags = (((ifam->ifa_flags
|
||
|
& (IFA_F_DEPRECATED
|
||
|
| IFA_F_OPTIMISTIC))
|
||
|
@@ -275,7 +289,7 @@ make_request (int fd, pid_t pid)
|
||
|
result = malloc (sizeof (*result)
|
||
|
+ in6ailistlen * sizeof (struct in6addrinfo));
|
||
|
if (result == NULL)
|
||
|
- goto out_fail;
|
||
|
+ goto out_fail2;
|
||
|
|
||
|
result->timestamp = get_nl_timestamp ();
|
||
|
result->usecnt = 2;
|
||
|
@@ -286,7 +300,10 @@ make_request (int fd, pid_t pid)
|
||
|
do
|
||
|
{
|
||
|
result->in6ai[--in6ailistlen] = in6ailist->info;
|
||
|
- in6ailist = in6ailist->next;
|
||
|
+ struct in6ailist *next = in6ailist->next;
|
||
|
+ if (in6ailist->use_malloc)
|
||
|
+ free (in6ailist);
|
||
|
+ in6ailist = next;
|
||
|
}
|
||
|
while (in6ailist != NULL);
|
||
|
}
|
||
|
@@ -302,7 +319,15 @@ make_request (int fd, pid_t pid)
|
||
|
free (buf);
|
||
|
return result;
|
||
|
|
||
|
-out_fail:
|
||
|
+ out_fail2:
|
||
|
+ while (in6ailist != NULL)
|
||
|
+ {
|
||
|
+ struct in6ailist *next = in6ailist->next;
|
||
|
+ if (in6ailist->use_malloc)
|
||
|
+ free (in6ailist);
|
||
|
+ in6ailist = next;
|
||
|
+ }
|
||
|
+ out_fail:
|
||
|
if (use_malloc)
|
||
|
free (buf);
|
||
|
return NULL;
|