forked from pool/glibc
Andreas Schwab
f066d6282a
* The <stdbit.h> header type-generic macros have been changed when using
GCC 14.1 or later to use __builtin_stdc_bit_ceil etc. built-in functions
* The GNU C Library now supports a feature test macro _ISOC23_SOURCE to
enable features from the ISO C23 standard
* The ISO C23 function families introduced in TS
18661-4:2015 are now supported in <math.h>
* A new tunable, glibc.rtld.enable_secure, can be used to run a program
as if it were a setuid process
* On Linux, the epoll header was updated to include epoll ioctl definitions
and the related structure added in Linux kernel 6.9
* The fortify functionality has been significantly enhanced for building
programs with clang against the GNU C Library
* Many functions have been added to the vector library for aarch64
* On x86, memset can now use non-temporal stores to improve the performance
of large writes
* Architectures which use a 32-bit seconds-since-epoch field in struct
lastlog, struct utmp, struct utmpx (such as i386, powerpc64le, rv32,
rv64, x86-64) switched from a signed to an unsigned type for that
field
* __rseq_size now denotes the size of the active rseq area (20 bytes
initially), not the size of struct rseq (32 bytes initially).
- arm-dl-start-user.patch, duplocale-global-locale.patch,
elf-parse-tunables.patch,
glibc-CVE-2024-33599-nscd-Stack-based-buffer-overflow-in-n.patch,
glibc-CVE-2024-33600-nscd-Avoid-null-pointer-crashes-after.patch,
glibc-CVE-2024-33600-nscd-Do-not-send-missing-not-found-re.patch,
glibc-CVE-2024-33601-CVE-2024-33602-nscd-netgroup-Use-two.patch,
iconv-iso-2022-cn-ext.patch, nscd-netgroup-cache-timeout.patch,
s390-clone-error-clobber-r7.patch, sigisemptyset.patch,
OBS-URL: https://build.opensuse.org/package/show/Base:System/glibc?expand=0&rev=719
61 lines
2.4 KiB
Diff
61 lines
2.4 KiB
Diff
From c99f886de54446cd4447db6b44be93dabbdc2f8b Mon Sep 17 00:00:00 2001
|
|
From: Florian Weimer <fweimer@redhat.com>
|
|
Date: Thu, 25 Apr 2024 15:01:07 +0200
|
|
Subject: [PATCH] CVE-2024-33600: nscd: Avoid null pointer crashes after
|
|
notfound response (bug 31678)
|
|
|
|
The addgetnetgrentX call in addinnetgrX may have failed to produce
|
|
a result, so the result variable in addinnetgrX can be NULL.
|
|
Use db->negtimeout as the fallback value if there is no result data;
|
|
the timeout is also overwritten below.
|
|
|
|
Also avoid sending a second not-found response. (The client
|
|
disconnects after receiving the first response, so the data stream did
|
|
not go out of sync even without this fix.) It is still beneficial to
|
|
add the negative response to the mapping, so that the client can get
|
|
it from there in the future, instead of going through the socket.
|
|
|
|
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
|
|
(cherry picked from commit b048a482f088e53144d26a61c390bed0210f49f2)
|
|
---
|
|
nscd/netgroupcache.c | 11 +++++++----
|
|
1 file changed, 7 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c
|
|
index c18fe111f3..e22ffa5884 100644
|
|
--- a/nscd/netgroupcache.c
|
|
+++ b/nscd/netgroupcache.c
|
|
@@ -511,14 +511,15 @@ addinnetgrX (struct database_dyn *db, int fd, request_header *req,
|
|
|
|
datahead_init_pos (&dataset->head, sizeof (*dataset) + req->key_len,
|
|
sizeof (innetgroup_response_header),
|
|
- he == NULL ? 0 : dh->nreloads + 1, result->head.ttl);
|
|
+ he == NULL ? 0 : dh->nreloads + 1,
|
|
+ result == NULL ? db->negtimeout : result->head.ttl);
|
|
/* Set the notfound status and timeout based on the result from
|
|
getnetgrent. */
|
|
- dataset->head.notfound = result->head.notfound;
|
|
+ dataset->head.notfound = result == NULL || result->head.notfound;
|
|
dataset->head.timeout = timeout;
|
|
|
|
dataset->resp.version = NSCD_VERSION;
|
|
- dataset->resp.found = result->resp.found;
|
|
+ dataset->resp.found = result != NULL && result->resp.found;
|
|
/* Until we find a matching entry the result is 0. */
|
|
dataset->resp.result = 0;
|
|
|
|
@@ -566,7 +567,9 @@ addinnetgrX (struct database_dyn *db, int fd, request_header *req,
|
|
goto out;
|
|
}
|
|
|
|
- if (he == NULL)
|
|
+ /* addgetnetgrentX may have already sent a notfound response. Do
|
|
+ not send another one. */
|
|
+ if (he == NULL && dataset->resp.found)
|
|
{
|
|
/* We write the dataset before inserting it to the database
|
|
since while inserting this thread might block and so would
|
|
--
|
|
2.45.0
|
|
|