From 1e2f03928b01aeb3ce2a5e28fc0621b5d7507ee5890bbf6d9a4f5ba72802f2c3 Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger Date: Tue, 21 Nov 2017 15:31:06 +0000 Subject: [PATCH 1/3] Accepting request 542978 from home:xiaoguang_wang:branches:GNOME:Factory - Add gnome-shell-extensions-window-list-app-icon-not-shown.patch: Fix window-list doesn't show app icon on taskbar when working in wayland (bgo#745064). OBS-URL: https://build.opensuse.org/request/show/542978 OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/gnome-shell-extensions?expand=0&rev=156 --- ...sions-window-list-app-icon-not-shown.patch | 41 +++++++++++++++++++ gnome-shell-extensions.changes | 7 ++++ gnome-shell-extensions.spec | 3 ++ 3 files changed, 51 insertions(+) create mode 100644 gnome-shell-extensions-window-list-app-icon-not-shown.patch diff --git a/gnome-shell-extensions-window-list-app-icon-not-shown.patch b/gnome-shell-extensions-window-list-app-icon-not-shown.patch new file mode 100644 index 0000000..d7ba760 --- /dev/null +++ b/gnome-shell-extensions-window-list-app-icon-not-shown.patch @@ -0,0 +1,41 @@ +From 9e9064463b6a175d39ed1bda5e10a2a51f9db962 Mon Sep 17 00:00:00 2001 +From: Xiaoguang Wang +Date: Sat, 4 Nov 2017 15:16:29 +0800 +Subject: [PATCH] window-list: App icon not shown on the taskbar + +Some application can't show icon when working in wayland. +Use application state change signal to update app icon. + +https://bugzilla.gnome.org/show_bug.cgi?id=745064 +--- + extensions/window-list/extension.js | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/extensions/window-list/extension.js b/extensions/window-list/extension.js +index f01b872..6d341ce 100644 +--- a/extensions/window-list/extension.js ++++ b/extensions/window-list/extension.js +@@ -167,6 +167,11 @@ const WindowTitle = new Lang.Class({ + this._notifyAppId = + this._metaWindow.connect('notify::gtk-application-id', + Lang.bind(this, this._updateIcon)); ++ ++ let appSys = Shell.AppSystem.get_default(); ++ this._appStateChangedSignalId = ++ appSys.connect('app-state-changed', Lang.bind(this, this._updateIcon)); ++ + this._updateIcon(); + + this.actor.connect('destroy', Lang.bind(this, this._onDestroy)); +@@ -210,6 +215,9 @@ const WindowTitle = new Lang.Class({ + this._metaWindow.disconnect(this._notifyMinimizedId); + this._metaWindow.disconnect(this._notifyWmClass); + this._metaWindow.disconnect(this._notifyAppId); ++ ++ let appSys = Shell.AppSystem.get_default(); ++ appSys.disconnect(this._appStateChangedSignalId); + } + }); + +-- +2.13.6 diff --git a/gnome-shell-extensions.changes b/gnome-shell-extensions.changes index 4a45969..bde22cb 100644 --- a/gnome-shell-extensions.changes +++ b/gnome-shell-extensions.changes @@ -1,3 +1,10 @@ +------------------------------------------------------------------- +Mon Nov 20 03:05:29 UTC 2017 - xwang@suse.com + +- Add gnome-shell-extensions-window-list-app-icon-not-shown.patch: + Fix window-list doesn't show app icon on taskbar when working in + wayland (bgo#745064). + ------------------------------------------------------------------- Thu Nov 9 01:37:47 UTC 2017 - xwang@suse.com diff --git a/gnome-shell-extensions.spec b/gnome-shell-extensions.spec index fa66098..d796fbe 100644 --- a/gnome-shell-extensions.spec +++ b/gnome-shell-extensions.spec @@ -38,6 +38,8 @@ Patch1: gnome-shell-add-app-to-desktop.patch Patch2: gnome-shell-favorites-menu-at-end.patch # PATCH-FEATURE-SLE sle-classic-lock-screen-background.patch bsc#1007468 xwang@suse.com -- add SUSE logo on lock screen when auth is requested Patch3: sle-classic-lock-screen-background.patch +# PATCH-FIX-UPSTREAM gnome-shell-extensions-window-list-app-icon-not-shown.patch bgo#745064 xwang@suse.com -- window-list application icon don't show on taskbar +Patch4: gnome-shell-extensions-window-list-app-icon-not-shown.patch ## NOTE keep SLE Classic patch at the bottom # PATCH-FIX-SLE gse-sle-classic-ext.patch Fate#318572 cxiong@suse.com -- add sle classic support Patch1000: gse-sle-classic-ext.patch @@ -105,6 +107,7 @@ translation-update-upstream gnome-patch-translation-prepare %patch3 -p1 %endif +%patch4 -p1 %patch1000 -p1 ##gnome-patch-translation-update # In openSUSE GNOME, we don't launch gnome-session directly, but wrap this through a shell script, /usr/bin/gnome From 3b66fe1ddd3e97a5345fa21ab37ba994013eddad784c8c393ad0ef8beb8c46f3 Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger Date: Fri, 24 Nov 2017 09:45:58 +0000 Subject: [PATCH 2/3] Accepting request 545002 from home:xiaoguang_wang:branches:GNOME:Factory - Apply GNOME session as default session on SLE (fate#324384). OBS-URL: https://build.opensuse.org/request/show/545002 OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/gnome-shell-extensions?expand=0&rev=157 --- gnome-shell-extensions.changes | 5 +++++ gnome-shell-extensions.spec | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gnome-shell-extensions.changes b/gnome-shell-extensions.changes index bde22cb..a301e19 100644 --- a/gnome-shell-extensions.changes +++ b/gnome-shell-extensions.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Nov 24 01:02:22 UTC 2017 - xwang@suse.com + +- Apply GNOME session as default session on SLE (fate#324384). + ------------------------------------------------------------------- Mon Nov 20 03:05:29 UTC 2017 - xwang@suse.com diff --git a/gnome-shell-extensions.spec b/gnome-shell-extensions.spec index d796fbe..51915a4 100644 --- a/gnome-shell-extensions.spec +++ b/gnome-shell-extensions.spec @@ -158,9 +158,9 @@ ln -s %{_sysconfdir}/alternatives/default-waylandsession.desktop %{buildroot}%{_ %if !0%{?is_opensuse} %post -n gnome-shell-classic %{_sbindir}/update-alternatives --install %{_datadir}/xsessions/default.desktop \ - default-xsession.desktop %{_datadir}/xsessions/sle-classic.desktop 30 + default-xsession.desktop %{_datadir}/xsessions/sle-classic.desktop 20 %{_sbindir}/update-alternatives --install %{_datadir}/wayland-sessions/default.desktop \ - default-waylandsession.desktop %{_datadir}/wayland-sessions/sle-classic.desktop 30 + default-waylandsession.desktop %{_datadir}/wayland-sessions/sle-classic.desktop 20 %postun -n gnome-shell-classic [ -f %{_datadir}/xsessions/sle-classic.desktop ] || %{_sbindir}/update-alternatives \ From 8018d5ec494ab3f4a2f8c782ca985bcecd72455402a6c809a5cfc1865d8d25bb Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger Date: Fri, 24 Nov 2017 09:47:10 +0000 Subject: [PATCH 3/3] tweak OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/gnome-shell-extensions?expand=0&rev=158 --- gnome-shell-extensions.changes | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnome-shell-extensions.changes b/gnome-shell-extensions.changes index a301e19..69f74b4 100644 --- a/gnome-shell-extensions.changes +++ b/gnome-shell-extensions.changes @@ -1,7 +1,9 @@ ------------------------------------------------------------------- Fri Nov 24 01:02:22 UTC 2017 - xwang@suse.com -- Apply GNOME session as default session on SLE (fate#324384). +- Lower update-alternative priority of sle-classic desktop to 20, + resulting in GNOME session becoming the default session + (fate#324384). ------------------------------------------------------------------- Mon Nov 20 03:05:29 UTC 2017 - xwang@suse.com