SHA256
1
0
forked from pool/grep

Accepting request 211831 from openSUSE:Factory:PowerLE

The "gnulib" package contains a number of floating-point test cases
that do not work correctly with the PowerPC long double ("double double")
format.  These tests "accidentally" succeeded anyway in the big-endian
variant, but are now actually failing in little-endian mode.

As is usual for gnulib, those tests end up copied into the source code
of various packages that use gnulib, including coreutils, findutils,
grep, and libunistring.

A patch to fix the tests for ppc64le has been submitted to upstream
to the bug-gnulib mailing list.  We'll work with upstream of the
other affected packages to make sure the copies are refreshed.

- grep-gnulib-ppc64le.patch: Fix imported gnulib long double math
  tests for little-endian PowerPC.

OBS-URL: https://build.opensuse.org/request/show/211831
OBS-URL: https://build.opensuse.org/package/show/Base:System/grep?expand=0&rev=36
This commit is contained in:
Dr. Werner Fink 2013-12-22 21:33:10 +00:00 committed by Git OBS Bridge
parent 78dd48e433
commit 923a5384a0
3 changed files with 50 additions and 0 deletions

41
grep-gnulib-ppc64le.patch Normal file
View File

@ -0,0 +1,41 @@
diff --git a/gnulib-tests/test-isnanl.h b/gnulib-tests/test-isnanl.h
index 06e6a7c..2df10f8 100644
--- a/gnulib-tests/test-isnanl.h
+++ b/gnulib-tests/test-isnanl.h
@@ -51,6 +51,15 @@ main ()
/* A bit pattern that is different from a Quiet NaN. With a bit of luck,
it's a Signalling NaN. */
{
+#if defined __powerpc__ && LDBL_MANT_DIG == 106
+ /* This is PowerPC "double double", a pair of two doubles. Inf and Nan are
+ represented as the corresponding 64-bit IEEE values in the first double;
+ the second is ignored. Manipulate only the first double. */
+ #undef NWORDS
+ #define NWORDS \
+ ((sizeof (double) + sizeof (unsigned int) - 1) / sizeof (unsigned int))
+#endif
+
memory_long_double m;
m.value = NaNl ();
# if LDBL_EXPBIT0_BIT > 0
diff --git a/gnulib-tests/test-signbit.c b/gnulib-tests/test-signbit.c
index e8ea097..7e24292 100644
--- a/gnulib-tests/test-signbit.c
+++ b/gnulib-tests/test-signbit.c
@@ -151,6 +151,16 @@ test_signbitl ()
#define NWORDS \
((sizeof (long double) + sizeof (unsigned int) - 1) / sizeof (unsigned int))
typedef union { long double value; unsigned int word[NWORDS]; } memory_long_double;
+
+#if defined __powerpc__ && LDBL_MANT_DIG == 106
+ /* This is PowerPC "double double", a pair of two doubles. Inf and Nan are
+ represented as the corresponding 64-bit IEEE values in the first double;
+ the second is ignored. Manipulate only the first double. */
+ #undef NWORDS
+ #define NWORDS \
+ ((sizeof (double) + sizeof (unsigned int) - 1) / sizeof (unsigned int))
+#endif
+
memory_long_double m;
m.value = zerol / zerol;
# if LDBL_EXPBIT0_BIT > 0

View File

@ -1,3 +1,9 @@
-------------------------------------------------------------------
Fri Dec 20 01:36:52 UTC 2013 - uweigand@de.ibm.com
- grep-gnulib-ppc64le.patch: Fix imported gnulib long double math
tests for little-endian PowerPC.
-------------------------------------------------------------------
Wed Dec 11 20:36:13 UTC 2013 - andreas.stieger@gmx.de

View File

@ -34,6 +34,8 @@ Group: Productivity/Text/Utilities
Source0: http://ftp.gnu.org/gnu/%{name}/%{name}-%{version}.tar.xz
Source2: http://ftp.gnu.org/gnu/%{name}/%{name}-%{version}.tar.xz.sig
Source3: http://savannah.gnu.org/project/memberlist-gpgkeys.php?group=grep&download=1#/%{name}.keyring
# Fix imported gnulib long double math tests for little-endian PowerPC
Patch1: grep-gnulib-ppc64le.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-build
%description
@ -43,6 +45,7 @@ the matching lines.
%prep
%setup -q
%patch1 -p1
%if 0%{?suse_version} < 1120
echo "ac_cv_search_pcre_compile=\${ac_cv_search_pcre_compile=%{_libdir}/libpcre.a}" >config.cache
%endif