forked from pool/grub2
e016790fe1
- Security fixes and hardenings for boothole 3 / boothole 2022 (bsc#1198581) * 0001-video-Remove-trailing-whitespaces.patch * 0002-loader-efi-chainloader-Simplify-the-loader-state.patch * 0003-commands-boot-Add-API-to-pass-context-to-loader.patch - Fix CVE-2022-28736 (bsc#1198496) * 0004-loader-efi-chainloader-Use-grub_loader_set_ex.patch - Fix CVE-2022-28735 (bsc#1198495) * 0005-kern-efi-sb-Reject-non-kernel-files-in-the-shim_lock.patch * 0006-kern-file-Do-not-leak-device_name-on-error-in-grub_f.patch * 0007-video-readers-png-Abort-sooner-if-a-read-operation-f.patch * 0008-video-readers-png-Refuse-to-handle-multiple-image-he.patch - Fix CVE-2021-3695 (bsc#1191184) * 0009-video-readers-png-Drop-greyscale-support-to-fix-heap.patch - Fix CVE-2021-3696 (bsc#1191185) * 0010-video-readers-png-Avoid-heap-OOB-R-W-inserting-huff-.patch * 0011-video-readers-png-Sanity-check-some-huffman-codes.patch * 0012-video-readers-jpeg-Abort-sooner-if-a-read-operation-.patch * 0013-video-readers-jpeg-Do-not-reallocate-a-given-huff-ta.patch * 0014-video-readers-jpeg-Refuse-to-handle-multiple-start-o.patch - Fix CVE-2021-3697 (bsc#1191186) * 0015-video-readers-jpeg-Block-int-underflow-wild-pointer-.patch * 0016-normal-charset-Fix-array-out-of-bounds-formatting-un.patch - Fix CVE-2022-28733 (bsc#1198460) * 0017-net-ip-Do-IP-fragment-maths-safely.patch * 0018-net-netbuff-Block-overly-large-netbuff-allocs.patch * 0019-net-dns-Fix-double-free-addresses-on-corrupt-DNS-res.patch * 0020-net-dns-Don-t-read-past-the-end-of-the-string-we-re-.patch * 0021-net-tftp-Prevent-a-UAF-and-double-free-from-a-failed.patch * 0022-net-tftp-Avoid-a-trivial-UAF.patch * 0023-net-http-Do-not-tear-down-socket-if-it-s-already-bee.patch OBS-URL: https://build.opensuse.org/request/show/981228 OBS-URL: https://build.opensuse.org/package/show/Base:System/grub2?expand=0&rev=416
45 lines
1.5 KiB
Diff
45 lines
1.5 KiB
Diff
From 7ec48289eeae517e14e2c957a90fd95a49741894 Mon Sep 17 00:00:00 2001
|
|
From: Daniel Axtens <dja@axtens.net>
|
|
Date: Tue, 1 Mar 2022 23:14:15 +1100
|
|
Subject: [PATCH 23/32] net/http: Do not tear down socket if it's already been
|
|
torn down
|
|
|
|
It's possible for data->sock to get torn down in tcp error handling.
|
|
If we unconditionally tear it down again we will end up doing writes
|
|
to an offset of the NULL pointer when we go to tear it down again.
|
|
|
|
Detect if it has been torn down and don't do it again.
|
|
|
|
Signed-off-by: Daniel Axtens <dja@axtens.net>
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
---
|
|
grub-core/net/http.c | 5 +++--
|
|
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/grub-core/net/http.c b/grub-core/net/http.c
|
|
index bf838660d9..a77bc4e4b8 100644
|
|
--- a/grub-core/net/http.c
|
|
+++ b/grub-core/net/http.c
|
|
@@ -425,7 +425,7 @@ http_establish (struct grub_file *file, grub_off_t offset, int initial)
|
|
return err;
|
|
}
|
|
|
|
- for (i = 0; !data->headers_recv && i < 100; i++)
|
|
+ for (i = 0; data->sock && !data->headers_recv && i < 100; i++)
|
|
{
|
|
grub_net_tcp_retransmit ();
|
|
grub_net_poll_cards (300, &data->headers_recv);
|
|
@@ -433,7 +433,8 @@ http_establish (struct grub_file *file, grub_off_t offset, int initial)
|
|
|
|
if (!data->headers_recv)
|
|
{
|
|
- grub_net_tcp_close (data->sock, GRUB_NET_TCP_ABORT);
|
|
+ if (data->sock)
|
|
+ grub_net_tcp_close (data->sock, GRUB_NET_TCP_ABORT);
|
|
if (data->err)
|
|
{
|
|
char *str = data->errmsg;
|
|
--
|
|
2.34.1
|
|
|