Accepting request 1195753 from multimedia:libs

OBS-URL: https://build.opensuse.org/request/show/1195753
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/gstreamer-plugins-base?expand=0&rev=107

gst-plugins-base-1.24.6.tar.xz

@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:cf52b535a0ce7ec974756891818f34f06317c2e136abb24149e18c23ecc229b5
-size 2436400

gst-plugins-base-decodebin3-collection-identity-check.patch

@@ -0,0 +1,67 @@
+From 378e78f285a3f14c0c53473948090464fa48147b Mon Sep 17 00:00:00 2001
+From: Edward Hervey <edward@centricular.com>
+Date: Wed, 21 Aug 2024 16:29:03 +0200
+Subject: [PATCH] decodebin3: Fix collection identity check
+
+Collections can be auto-generated from upstream and yet have exactly the same
+streams in it.
+
+Therefore do a more in-depth check for equality.
+
+Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3742
+---
+ .../gst/playback/gstdecodebin3.c              | 26 ++++++++++++++++++-
+ 1 file changed, 25 insertions(+), 1 deletion(-)
+
+diff --git a/gst/playback/gstdecodebin3.c b/gst/playback/gstdecodebin3.c
+index 56ef496468ac..78b79c776ba6 100644
+--- a/gst/playback/gstdecodebin3.c
++++ b/gst/playback/gstdecodebin3.c
+@@ -2609,6 +2609,29 @@ db_collection_new (GstStreamCollection * collection)
+   return db_collection;
+ }
+ 
++static gboolean
++collections_are_identical (GstStreamCollection * collection,
++    GstStreamCollection * previous)
++{
++  guint i;
++
++  if (collection == previous)
++    return TRUE;
++
++  if (gst_stream_collection_get_size (collection) !=
++      gst_stream_collection_get_size (previous))
++    return FALSE;
++
++  for (i = 0; i < gst_stream_collection_get_size (previous); i++) {
++    GstStream *stream = gst_stream_collection_get_stream (previous, i);
++    const gchar *sid = gst_stream_get_stream_id (stream);
++    if (!stream_in_collection (collection, (gchar *) sid))
++      return FALSE;
++  }
++
++  return TRUE;
++}
++
+ /** handle_stream_collection_locked:
+  * @dbin:
+  * @collection: (transfer none): The new collection for @input. Can be %NULL.
+@@ -2683,12 +2706,13 @@ handle_stream_collection_locked (GstDecodebin3 * dbin,
+   if (dbin->input_collection) {
+     GstStreamCollection *previous = dbin->input_collection->collection;
+ 
+-    if (collection == previous) {
++    if (collections_are_identical (collection, previous)) {
+       GST_DEBUG_OBJECT (dbin, "Collection didn't change");
+       gst_object_unref (collection);
+       SELECTION_UNLOCK (dbin);
+       return NULL;
+     }
++
+     /* Check if this collection is an update of the previous one */
+     if (gst_stream_collection_get_size (collection) >
+         gst_stream_collection_get_size (previous)) {
+-- 
+GitLab
+

gstreamer-plugins-base.changes

@@ -1,3 +1,23 @@
+-------------------------------------------------------------------
+Fri Aug 23 07:15:20 UTC 2024 - Bjørn Lie <bjorn.lie@gmail.com>
+
+- Update to version 1.24.7:
+  + pbutils: descriptions: use subsampling factor to get YUV
+    subsampling
+  + rtspconnection: Handle invalid argument properly
+  + urisourcebin:
+    - Actually drop EOS on old-school pad switch
+    - Don't hold lock when emitting about-to-finish
+  + gst-launch deadlock with two playbin3s
+  + xvimagesink: Fix crash in pool on error
+
+-------------------------------------------------------------------
+Wed Aug 21 15:43:45 UTC 2024 - Jonas Kvinge <jonaski@opensuse.org>
+
+- Add gst-plugins-base-decodebin3-collection-identity-check.patch:
+  - Fixes a assertion causing crash on track change. Upstream bug:
+    https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3742
+
 -------------------------------------------------------------------
 Wed Jul 31 13:41:59 UTC 2024 - Dominique Leuenberger <dimstar@opensuse.org>
 

gstreamer-plugins-base.spec

@@ -20,7 +20,7 @@
 %define gst_branch 1.0
 %define gstreamer_req_version %(echo %{version} | sed -e "s/+.*//")
 Name:           gstreamer-plugins-base
-Version:        1.24.6
+Version:        1.24.7
 Release:        0
 Summary:        GStreamer Streaming-Media Framework Plug-Ins
 License:        GPL-2.0-or-later AND LGPL-2.1-or-later
@@ -31,6 +31,7 @@ Source1:        gstreamer-plugins-base.appdata.xml
 Source2:        baselibs.conf
 Patch1:         add_wayland_dep_to_tests.patch
 Patch2:         MR-221-video-anc-add-two-new-CEA-608-caption-formats.patch
+Patch3:         gst-plugins-base-decodebin3-collection-identity-check.patch
 
 BuildRequires:  Mesa-libGLESv3-devel
 BuildRequires:  cdparanoia-devel