28 lines
1.2 KiB
Diff
28 lines
1.2 KiB
Diff
|
I: Statement might be overflowing a buffer in strncat. Common mistake:
|
||
|
|
BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the left over size as 3rd argument
|
||
|
|
GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1)
|
||
|
|
E: icu bufferoverflowstrncat pkgdata.cpp:299:87
|
||
|
|
|
||
|
|
---
|
||
|
|
source/tools/pkgdata/pkgdata.cpp | 6 +++---
|
||
|
|
2 files changed, 4 insertions(+), 4 deletions(-)
|
||
|
|
|
||
|
|
Index: icu/source/tools/pkgdata/pkgdata.cpp
|
||
|
|
===================================================================
|
||
|
|
--- icu.orig/source/tools/pkgdata/pkgdata.cpp
|
||
|
|
+++ icu/source/tools/pkgdata/pkgdata.cpp
|
||
|
|
@@ -1645,10 +1645,10 @@ static void loadLists(UPKGOptions *o, UE
|
||
|
|
const char cmd[] = "icu-config --incpkgdatafile";
|
||
|
|
|
||
|
|
/* #1 try the same path where pkgdata was called from. */
|
||
|
|
- findDirname(progname, cmdBuf, 1024, &status);
|
||
|
|
+ findDirname(progname, cmdBuf, sizeof(cmdBuf), &status);
|
||
|
|
if(U_SUCCESS(status)) {
|
||
|
|
- uprv_strncat(cmdBuf, U_FILE_SEP_STRING, 1024);
|
||
|
|
- uprv_strncat(cmdBuf, cmd, 1024);
|
||
|
|
+ uprv_strncat(cmdBuf, U_FILE_SEP_STRING, sizeof(cmdBuf)-1-strlen(cmdBuf));
|
||
|
|
+ uprv_strncat(cmdBuf, cmd, sizeof(cmdBuf)-1-strlen(cmdBuf));
|
||
|
|
|
||
|
|
if(verbose) {
|
||
|
|
fprintf(stdout, "# Calling icu-config: %s\n", cmdBuf);
|