From 435ed5853b9451ab8fdfff722545c57a8f154625 Mon Sep 17 00:00:00 2001 From: Fabian Vogt Date: Sat, 18 Feb 2017 13:49:14 +0100 Subject: [PATCH] Defuse root block While the main point is correct as any application running in the same X session (not sandboxed) can use kate's capability to open a console, we allow (even encourage) running YaST on X11 as root. That way it's only an impact on usability. --- kate/main.cpp | 3 +-- kwrite/main.cpp | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) Index: kate-18.07.70git.20180531T121543~bf6d5b753/kate/main.cpp =================================================================== --- kate-18.07.70git.20180531T121543~bf6d5b753.orig/kate/main.cpp +++ kate-18.07.70git.20180531T121543~bf6d5b753/kate/main.cpp @@ -63,13 +63,8 @@ int main(int argc, char **argv) #ifndef Q_OS_WIN // Prohibit using sudo or kdesu (but allow using the root user directly) if (getuid() == 0) { - if (!qEnvironmentVariableIsEmpty("SUDO_USER")) { - std::cout << "Executing Kate with sudo is not possible due to unfixable security vulnerabilities." << std::endl; - return EXIT_FAILURE; - } else if (!qEnvironmentVariableIsEmpty("KDESU_USER")) { - std::cout << "Executing Kate with kdesu is not possible due to unfixable security vulnerabilities." << std::endl; - return EXIT_FAILURE; - } + std::cout << "THIS IS POTENTIALLY INSECURE!\nTo edit files as root please use:" << std::endl; + std::cout << "SUDO_EDITOR=kwrite sudoedit " << std::endl; } #endif /** Index: kate-18.07.70git.20180531T121543~bf6d5b753/kwrite/main.cpp =================================================================== --- kate-18.07.70git.20180531T121543~bf6d5b753.orig/kwrite/main.cpp +++ kate-18.07.70git.20180531T121543~bf6d5b753/kwrite/main.cpp @@ -52,13 +52,8 @@ extern "C" Q_DECL_EXPORT int main(int ar #ifndef Q_OS_WIN // Prohibit using sudo or kdesu (but allow using the root user directly) if (getuid() == 0) { - if (!qEnvironmentVariableIsEmpty("SUDO_USER")) { - std::cout << "Executing Kate with sudo is not possible due to unfixable security vulnerabilities." << std::endl; - return EXIT_FAILURE; - } else if (!qEnvironmentVariableIsEmpty("KDESU_USER")) { - std::cout << "Executing Kate with kdesu is not possible due to unfixable security vulnerabilities." << std::endl; - return EXIT_FAILURE; - } + std::cout << "THIS IS POTENTIALLY INSECURE!\nTo edit files as root please use:" << std::endl; + std::cout << "SUDO_EDITOR=kwrite sudoedit " << std::endl; } #endif /**