2015-07-31 20:53:33 +02:00
|
|
|
From 710088061fb3caaf3d56888b05ad2d331a740d07 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Jim Fehlig <jfehlig@suse.com>
|
|
|
|
Date: Thu, 16 Jul 2015 14:51:32 -0600
|
|
|
|
Subject: libxl: acquire a job when receiving a migrating domain
|
|
|
|
|
|
|
|
Commit f86ae403 moved acquiring a job from libxlDomainStart()
|
|
|
|
to its callers. One spot missed was in libxlDoMigrateReceive().
|
|
|
|
Acquire a job in libxlDoMigrateReceive() before calling
|
|
|
|
libxlDomainStart().
|
|
|
|
|
|
|
|
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
|
|
|
|
---
|
|
|
|
src/libxl/libxl_migration.c | 20 +++++++++++++++++---
|
|
|
|
1 file changed, 17 insertions(+), 3 deletions(-)
|
|
|
|
|
2015-08-04 17:13:51 +02:00
|
|
|
Index: libvirt-1.2.18/src/libxl/libxl_migration.c
|
2015-07-31 20:53:33 +02:00
|
|
|
===================================================================
|
2015-08-04 17:13:51 +02:00
|
|
|
--- libvirt-1.2.18.orig/src/libxl/libxl_migration.c
|
|
|
|
+++ libvirt-1.2.18/src/libxl/libxl_migration.c
|
2015-07-31 20:53:33 +02:00
|
|
|
@@ -95,17 +95,20 @@ libxlDoMigrateReceive(void *opaque)
|
|
|
|
int recvfd = args->recvfd;
|
|
|
|
size_t i;
|
|
|
|
int ret;
|
|
|
|
+ bool remove_dom = 0;
|
|
|
|
+
|
|
|
|
+ virObjectLock(vm);
|
|
|
|
+ if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0)
|
|
|
|
+ goto cleanup;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Always start the domain paused. If needed, unpause in the
|
|
|
|
* finish phase, after transfer of the domain is complete.
|
|
|
|
*/
|
|
|
|
- virObjectLock(vm);
|
|
|
|
ret = libxlDomainStart(driver, vm, true, recvfd);
|
|
|
|
- virObjectUnlock(vm);
|
|
|
|
|
|
|
|
if (ret < 0 && !vm->persistent)
|
|
|
|
- virDomainObjListRemove(driver->domains, vm);
|
|
|
|
+ remove_dom = true;
|
|
|
|
|
|
|
|
/* Remove all listen socks from event handler, and close them. */
|
|
|
|
for (i = 0; i < nsocks; i++) {
|
|
|
|
@@ -117,6 +120,17 @@ libxlDoMigrateReceive(void *opaque)
|
|
|
|
args->nsocks = 0;
|
|
|
|
VIR_FORCE_CLOSE(recvfd);
|
|
|
|
virObjectUnref(args);
|
|
|
|
+
|
|
|
|
+ if (!libxlDomainObjEndJob(driver, vm))
|
|
|
|
+ vm = NULL;
|
|
|
|
+
|
|
|
|
+ cleanup:
|
|
|
|
+ if (remove_dom && vm) {
|
|
|
|
+ virDomainObjListRemove(driver->domains, vm);
|
|
|
|
+ vm = NULL;
|
|
|
|
+ }
|
|
|
|
+ if (vm)
|
|
|
|
+ virObjectUnlock(vm);
|
|
|
|
}
|
|
|
|
|
|
|
|
|