2016-02-23 23:12:48 +01:00
|
|
|
libxl: set script field of libxl_device_disk
|
|
|
|
|
|
|
|
Add a hack to the libvirt libxl driver to set
|
|
|
|
libxl_device_disk->script when the disk configuration starts
|
|
|
|
with some well-known Xen external block scripts: dmmd, drbd,
|
|
|
|
and npiv.
|
|
|
|
|
|
|
|
For more details, see bsc#954872 and FATE#319810
|
|
|
|
|
Accepting request 567780 from home:jfehlig:branches:Virtualization
- Update to libvirt 4.0.0
- Many incremental improvements and bug fixes, see
http://libvirt.org/news.html
- Dropped patches:
2d07f1f0-fix-storage-crash.patch,
69ed99c7-dom0-persistent.patch,
8599aedd-libvirt-guests-dom0-filter.patch,
0f33025a-virt-aa-helper-handle-more-disk-images.patch,
b475a91b-add-virStringFilterChars-string-utility.patch,
faec1958-lxc-set-hostname-based-on-container-name.patch,
2089ab21-netserver-close-clients-before-stopping-all-drivers.patch,
fix-virt-aa-helper-profile.patch,
suse-apparmor-signal.patch
- Patches added to fix upstream bugs:
72adaf2f-revert-qemu-monitor-error-report.patch,
71d56a39-nodedev-fix-parse-PCI-address.patch
- CVE-2018-5748, CVE-2017-5715, bsc#1071651
OBS-URL: https://build.opensuse.org/request/show/567780
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=661
2018-01-19 20:16:17 +01:00
|
|
|
Index: libvirt-4.0.0/src/libxl/libxl_conf.c
|
2016-02-23 23:12:48 +01:00
|
|
|
===================================================================
|
Accepting request 567780 from home:jfehlig:branches:Virtualization
- Update to libvirt 4.0.0
- Many incremental improvements and bug fixes, see
http://libvirt.org/news.html
- Dropped patches:
2d07f1f0-fix-storage-crash.patch,
69ed99c7-dom0-persistent.patch,
8599aedd-libvirt-guests-dom0-filter.patch,
0f33025a-virt-aa-helper-handle-more-disk-images.patch,
b475a91b-add-virStringFilterChars-string-utility.patch,
faec1958-lxc-set-hostname-based-on-container-name.patch,
2089ab21-netserver-close-clients-before-stopping-all-drivers.patch,
fix-virt-aa-helper-profile.patch,
suse-apparmor-signal.patch
- Patches added to fix upstream bugs:
72adaf2f-revert-qemu-monitor-error-report.patch,
71d56a39-nodedev-fix-parse-PCI-address.patch
- CVE-2018-5748, CVE-2017-5715, bsc#1071651
OBS-URL: https://build.opensuse.org/request/show/567780
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=661
2018-01-19 20:16:17 +01:00
|
|
|
--- libvirt-4.0.0.orig/src/libxl/libxl_conf.c
|
|
|
|
+++ libvirt-4.0.0/src/libxl/libxl_conf.c
|
2018-02-23 23:58:19 +01:00
|
|
|
@@ -769,6 +769,25 @@ libxlDiskSetDiscard(libxl_device_disk *x
|
2016-07-01 18:39:05 +02:00
|
|
|
#endif
|
2016-02-23 23:12:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+static int
|
|
|
|
+libxlDiskSetScript(libxl_device_disk *x_disk, const char *disk_spec)
|
|
|
|
+{
|
2016-03-02 21:40:27 +01:00
|
|
|
+ if (disk_spec == NULL)
|
|
|
|
+ return 0;
|
|
|
|
+
|
2016-02-23 23:12:48 +01:00
|
|
|
+ if (STRPREFIX(disk_spec, "dmmd:")) {
|
|
|
|
+ if (VIR_STRDUP(x_disk->script, "block-dmmd") < 0)
|
|
|
|
+ return -1;
|
|
|
|
+ } else if (STRPREFIX(disk_spec, "drbd:")) {
|
|
|
|
+ if (VIR_STRDUP(x_disk->script, "block-drbd") < 0)
|
|
|
|
+ return -1;
|
|
|
|
+ } else if (STRPREFIX(disk_spec, "npiv:")) {
|
|
|
|
+ if (VIR_STRDUP(x_disk->script, "block-npiv") < 0)
|
|
|
|
+ return -1;
|
|
|
|
+ }
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
2016-07-01 18:39:05 +02:00
|
|
|
static void
|
|
|
|
libxlDiskSetCacheMode(libxl_device_disk *x_disk, int cachemode)
|
|
|
|
{
|
2018-02-23 23:58:19 +01:00
|
|
|
@@ -914,6 +933,7 @@ libxlMakeNetworkDiskSrc(virStorageSource
|
2016-02-23 23:12:48 +01:00
|
|
|
int
|
|
|
|
libxlMakeDisk(virDomainDiskDefPtr l_disk, libxl_device_disk *x_disk)
|
|
|
|
{
|
|
|
|
+ const char *src = virDomainDiskGetSource(l_disk);
|
2016-05-25 16:57:57 +02:00
|
|
|
const char *driver = virDomainDiskGetDriver(l_disk);
|
|
|
|
int format = virDomainDiskGetFormat(l_disk);
|
2016-03-01 18:58:15 +01:00
|
|
|
int actual_type = virStorageSourceGetActualType(l_disk->src);
|
2018-02-23 23:58:19 +01:00
|
|
|
@@ -929,7 +949,7 @@ libxlMakeDisk(virDomainDiskDefPtr l_disk
|
2016-03-01 18:58:15 +01:00
|
|
|
if (libxlMakeNetworkDiskSrc(l_disk->src, &x_disk->pdev_path) < 0)
|
|
|
|
return -1;
|
|
|
|
} else {
|
|
|
|
- if (VIR_STRDUP(x_disk->pdev_path, virDomainDiskGetSource(l_disk)) < 0)
|
|
|
|
+ if (VIR_STRDUP(x_disk->pdev_path, src) < 0)
|
2016-02-23 23:12:48 +01:00
|
|
|
return -1;
|
2016-03-01 18:58:15 +01:00
|
|
|
}
|
2016-02-23 23:12:48 +01:00
|
|
|
|
2018-02-23 23:58:19 +01:00
|
|
|
@@ -1042,6 +1062,9 @@ libxlMakeDisk(virDomainDiskDefPtr l_disk
|
2016-02-23 23:12:48 +01:00
|
|
|
if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0)
|
|
|
|
return -1;
|
2016-06-24 19:07:56 +02:00
|
|
|
libxlDiskSetCacheMode(x_disk, l_disk->cachemode);
|
2016-02-23 23:12:48 +01:00
|
|
|
+ if (libxlDiskSetScript(x_disk, src) < 0)
|
|
|
|
+ return -1;
|
|
|
|
+
|
|
|
|
/* An empty CDROM must have the empty format, otherwise libxl fails. */
|
|
|
|
if (x_disk->is_cdrom && !x_disk->pdev_path)
|
|
|
|
x_disk->format = LIBXL_DISK_FORMAT_EMPTY;
|