2016-02-23 23:12:48 +01:00
|
|
|
libxl: set script field of libxl_device_disk
|
|
|
|
|
|
|
|
Add a hack to the libvirt libxl driver to set
|
|
|
|
libxl_device_disk->script when the disk configuration starts
|
|
|
|
with some well-known Xen external block scripts: dmmd, drbd,
|
|
|
|
and npiv.
|
|
|
|
|
|
|
|
For more details, see bsc#954872 and FATE#319810
|
|
|
|
|
2016-05-03 23:55:59 +02:00
|
|
|
Index: libvirt-1.3.4/src/libxl/libxl_conf.c
|
2016-02-23 23:12:48 +01:00
|
|
|
===================================================================
|
2016-05-03 23:55:59 +02:00
|
|
|
--- libvirt-1.3.4.orig/src/libxl/libxl_conf.c
|
|
|
|
+++ libvirt-1.3.4/src/libxl/libxl_conf.c
|
2016-04-13 02:22:05 +02:00
|
|
|
@@ -905,6 +905,25 @@ libxlDiskSetDiscard(libxl_device_disk *x
|
2016-02-23 23:12:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
+static int
|
|
|
|
+libxlDiskSetScript(libxl_device_disk *x_disk, const char *disk_spec)
|
|
|
|
+{
|
2016-03-02 21:40:27 +01:00
|
|
|
+ if (disk_spec == NULL)
|
|
|
|
+ return 0;
|
|
|
|
+
|
2016-02-23 23:12:48 +01:00
|
|
|
+ if (STRPREFIX(disk_spec, "dmmd:")) {
|
|
|
|
+ if (VIR_STRDUP(x_disk->script, "block-dmmd") < 0)
|
|
|
|
+ return -1;
|
|
|
|
+ } else if (STRPREFIX(disk_spec, "drbd:")) {
|
|
|
|
+ if (VIR_STRDUP(x_disk->script, "block-drbd") < 0)
|
|
|
|
+ return -1;
|
|
|
|
+ } else if (STRPREFIX(disk_spec, "npiv:")) {
|
|
|
|
+ if (VIR_STRDUP(x_disk->script, "block-npiv") < 0)
|
|
|
|
+ return -1;
|
|
|
|
+ }
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
#define LIBXL_QEMU_DM_STR "Options specific to the Xen version:"
|
|
|
|
|
|
|
|
int
|
2016-05-03 23:55:59 +02:00
|
|
|
@@ -1052,6 +1071,7 @@ libxlMakeNetworkDiskSrc(virStorageSource
|
2016-02-23 23:12:48 +01:00
|
|
|
int
|
|
|
|
libxlMakeDisk(virDomainDiskDefPtr l_disk, libxl_device_disk *x_disk)
|
|
|
|
{
|
|
|
|
+ const char *src = virDomainDiskGetSource(l_disk);
|
|
|
|
const char *driver;
|
|
|
|
int format;
|
2016-03-01 18:58:15 +01:00
|
|
|
int actual_type = virStorageSourceGetActualType(l_disk->src);
|
2016-05-03 23:55:59 +02:00
|
|
|
@@ -1062,7 +1082,7 @@ libxlMakeDisk(virDomainDiskDefPtr l_disk
|
2016-03-01 18:58:15 +01:00
|
|
|
if (libxlMakeNetworkDiskSrc(l_disk->src, &x_disk->pdev_path) < 0)
|
|
|
|
return -1;
|
|
|
|
} else {
|
|
|
|
- if (VIR_STRDUP(x_disk->pdev_path, virDomainDiskGetSource(l_disk)) < 0)
|
|
|
|
+ if (VIR_STRDUP(x_disk->pdev_path, src) < 0)
|
2016-02-23 23:12:48 +01:00
|
|
|
return -1;
|
2016-03-01 18:58:15 +01:00
|
|
|
}
|
2016-02-23 23:12:48 +01:00
|
|
|
|
2016-05-03 23:55:59 +02:00
|
|
|
@@ -1171,6 +1191,9 @@ libxlMakeDisk(virDomainDiskDefPtr l_disk
|
2016-02-23 23:12:48 +01:00
|
|
|
x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0;
|
|
|
|
if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0)
|
|
|
|
return -1;
|
|
|
|
+ if (libxlDiskSetScript(x_disk, src) < 0)
|
|
|
|
+ return -1;
|
|
|
|
+
|
|
|
|
/* An empty CDROM must have the empty format, otherwise libxl fails. */
|
|
|
|
if (x_disk->is_cdrom && !x_disk->pdev_path)
|
|
|
|
x_disk->format = LIBXL_DISK_FORMAT_EMPTY;
|