2022-09-02 00:07:34 +02:00
|
|
|
From 1f6dc6fbf1a0741edb6635a1798d1ac14802f8eb Mon Sep 17 00:00:00 2001
|
|
|
|
From: Jim Fehlig <jfehlig@suse.com>
|
|
|
|
Date: Tue, 5 Jul 2022 11:54:34 -0600
|
|
|
|
Subject: libxl: set script field of libxl_device_disk
|
2016-02-23 23:12:48 +01:00
|
|
|
|
|
|
|
Add a hack to the libvirt libxl driver to set
|
|
|
|
libxl_device_disk->script when the disk configuration starts
|
|
|
|
with some well-known Xen external block scripts: dmmd, drbd,
|
|
|
|
and npiv.
|
|
|
|
|
2022-09-02 00:07:34 +02:00
|
|
|
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
|
|
|
|
---
|
|
|
|
src/libxl/libxl_conf.c | 19 ++++++++++++++++++-
|
|
|
|
1 file changed, 18 insertions(+), 1 deletion(-)
|
2016-02-23 23:12:48 +01:00
|
|
|
|
Accepting request 1068569 from home:jfehlig:branches:Virtualization
- Update to libvirt 9.1.0
- Many incremental improvements and bug fixes, see
https://libvirt.org/news.html#v9-1-0-2023-03-01
- spec: Remove obsolete Groups tag
- spec: Integrate upstream spec file changes that split the
libvirt-daemon package, allowing more modular, customized
installations
- spec: New subpackages libvirt-daemon-common, libvirt-daemon-lock,
libvirt-daemon-log, libvirt-daemon-proxy, and
libvirt-daemon-plugin-lockd
- spec: Renamed subpackage libvirt-lock-sanlock to
libvirt-daemon-plugin-sanlock
- Dropped patches:
ef482951-apparmor-Allow-umount-dev.patch,
d6a8b9ee-qemu-Fix-managed-no-when-creating-ethdev.patch,
c3f16cea-qemu-cleanup-label-on-umount-failure.patch,
697c16e3-qemu_process-better-debug-message.patch,
5155ab4b-qemu_namespace-nested-mounts-when-umount.patch
OBS-URL: https://build.opensuse.org/request/show/1068569
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=968
2023-03-02 01:49:27 +01:00
|
|
|
Index: libvirt-9.1.0/src/libxl/libxl_conf.c
|
2016-02-23 23:12:48 +01:00
|
|
|
===================================================================
|
Accepting request 1068569 from home:jfehlig:branches:Virtualization
- Update to libvirt 9.1.0
- Many incremental improvements and bug fixes, see
https://libvirt.org/news.html#v9-1-0-2023-03-01
- spec: Remove obsolete Groups tag
- spec: Integrate upstream spec file changes that split the
libvirt-daemon package, allowing more modular, customized
installations
- spec: New subpackages libvirt-daemon-common, libvirt-daemon-lock,
libvirt-daemon-log, libvirt-daemon-proxy, and
libvirt-daemon-plugin-lockd
- spec: Renamed subpackage libvirt-lock-sanlock to
libvirt-daemon-plugin-sanlock
- Dropped patches:
ef482951-apparmor-Allow-umount-dev.patch,
d6a8b9ee-qemu-Fix-managed-no-when-creating-ethdev.patch,
c3f16cea-qemu-cleanup-label-on-umount-failure.patch,
697c16e3-qemu_process-better-debug-message.patch,
5155ab4b-qemu_namespace-nested-mounts-when-umount.patch
OBS-URL: https://build.opensuse.org/request/show/1068569
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=968
2023-03-02 01:49:27 +01:00
|
|
|
--- libvirt-9.1.0.orig/src/libxl/libxl_conf.c
|
|
|
|
+++ libvirt-9.1.0/src/libxl/libxl_conf.c
|
2023-01-18 23:49:05 +01:00
|
|
|
@@ -950,6 +950,20 @@ libxlDiskSetDiscard(libxl_device_disk *x
|
2016-02-23 23:12:48 +01:00
|
|
|
}
|
|
|
|
|
2021-09-01 18:17:27 +02:00
|
|
|
static void
|
2016-02-23 23:12:48 +01:00
|
|
|
+libxlDiskSetScript(libxl_device_disk *x_disk, const char *disk_spec)
|
|
|
|
+{
|
2016-03-02 21:40:27 +01:00
|
|
|
+ if (disk_spec == NULL)
|
2021-09-01 18:17:27 +02:00
|
|
|
+ return;
|
2016-03-02 21:40:27 +01:00
|
|
|
+
|
2020-01-16 02:52:12 +01:00
|
|
|
+ if (STRPREFIX(disk_spec, "dmmd:"))
|
|
|
|
+ x_disk->script = g_strdup("block-dmmd");
|
|
|
|
+ else if (STRPREFIX(disk_spec, "drbd:"))
|
|
|
|
+ x_disk->script = g_strdup("block-drbd");
|
|
|
|
+ else if (STRPREFIX(disk_spec, "npiv:"))
|
|
|
|
+ x_disk->script = g_strdup("block-npiv");
|
2016-02-23 23:12:48 +01:00
|
|
|
+}
|
|
|
|
+
|
2021-09-01 18:17:27 +02:00
|
|
|
+static void
|
2016-07-01 18:39:05 +02:00
|
|
|
libxlDiskSetCacheMode(libxl_device_disk *x_disk, int cachemode)
|
|
|
|
{
|
2021-09-01 18:17:27 +02:00
|
|
|
switch (cachemode) {
|
Accepting request 1068569 from home:jfehlig:branches:Virtualization
- Update to libvirt 9.1.0
- Many incremental improvements and bug fixes, see
https://libvirt.org/news.html#v9-1-0-2023-03-01
- spec: Remove obsolete Groups tag
- spec: Integrate upstream spec file changes that split the
libvirt-daemon package, allowing more modular, customized
installations
- spec: New subpackages libvirt-daemon-common, libvirt-daemon-lock,
libvirt-daemon-log, libvirt-daemon-proxy, and
libvirt-daemon-plugin-lockd
- spec: Renamed subpackage libvirt-lock-sanlock to
libvirt-daemon-plugin-sanlock
- Dropped patches:
ef482951-apparmor-Allow-umount-dev.patch,
d6a8b9ee-qemu-Fix-managed-no-when-creating-ethdev.patch,
c3f16cea-qemu-cleanup-label-on-umount-failure.patch,
697c16e3-qemu_process-better-debug-message.patch,
5155ab4b-qemu_namespace-nested-mounts-when-umount.patch
OBS-URL: https://build.opensuse.org/request/show/1068569
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=968
2023-03-02 01:49:27 +01:00
|
|
|
@@ -1087,6 +1101,7 @@ libxlMakeNetworkDiskSrc(virStorageSource
|
2016-02-23 23:12:48 +01:00
|
|
|
int
|
2021-05-18 00:14:02 +02:00
|
|
|
libxlMakeDisk(virDomainDiskDef *l_disk, libxl_device_disk *x_disk)
|
2016-02-23 23:12:48 +01:00
|
|
|
{
|
|
|
|
+ const char *src = virDomainDiskGetSource(l_disk);
|
2016-05-25 16:57:57 +02:00
|
|
|
const char *driver = virDomainDiskGetDriver(l_disk);
|
|
|
|
int format = virDomainDiskGetFormat(l_disk);
|
2022-07-06 19:18:39 +02:00
|
|
|
virStorageType actual_type = virStorageSourceGetActualType(l_disk->src);
|
Accepting request 1068569 from home:jfehlig:branches:Virtualization
- Update to libvirt 9.1.0
- Many incremental improvements and bug fixes, see
https://libvirt.org/news.html#v9-1-0-2023-03-01
- spec: Remove obsolete Groups tag
- spec: Integrate upstream spec file changes that split the
libvirt-daemon package, allowing more modular, customized
installations
- spec: New subpackages libvirt-daemon-common, libvirt-daemon-lock,
libvirt-daemon-log, libvirt-daemon-proxy, and
libvirt-daemon-plugin-lockd
- spec: Renamed subpackage libvirt-lock-sanlock to
libvirt-daemon-plugin-sanlock
- Dropped patches:
ef482951-apparmor-Allow-umount-dev.patch,
d6a8b9ee-qemu-Fix-managed-no-when-creating-ethdev.patch,
c3f16cea-qemu-cleanup-label-on-umount-failure.patch,
697c16e3-qemu_process-better-debug-message.patch,
5155ab4b-qemu_namespace-nested-mounts-when-umount.patch
OBS-URL: https://build.opensuse.org/request/show/1068569
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=968
2023-03-02 01:49:27 +01:00
|
|
|
@@ -1100,7 +1115,7 @@ libxlMakeDisk(virDomainDiskDef *l_disk,
|
2016-03-01 18:58:15 +01:00
|
|
|
if (libxlMakeNetworkDiskSrc(l_disk->src, &x_disk->pdev_path) < 0)
|
|
|
|
return -1;
|
|
|
|
} else {
|
2019-11-06 16:48:56 +01:00
|
|
|
- x_disk->pdev_path = g_strdup(virDomainDiskGetSource(l_disk));
|
|
|
|
+ x_disk->pdev_path = g_strdup(src);
|
2016-03-01 18:58:15 +01:00
|
|
|
}
|
2016-02-23 23:12:48 +01:00
|
|
|
|
2019-11-06 16:48:56 +01:00
|
|
|
x_disk->vdev = g_strdup(l_disk->dst);
|
Accepting request 1068569 from home:jfehlig:branches:Virtualization
- Update to libvirt 9.1.0
- Many incremental improvements and bug fixes, see
https://libvirt.org/news.html#v9-1-0-2023-03-01
- spec: Remove obsolete Groups tag
- spec: Integrate upstream spec file changes that split the
libvirt-daemon package, allowing more modular, customized
installations
- spec: New subpackages libvirt-daemon-common, libvirt-daemon-lock,
libvirt-daemon-log, libvirt-daemon-proxy, and
libvirt-daemon-plugin-lockd
- spec: Renamed subpackage libvirt-lock-sanlock to
libvirt-daemon-plugin-sanlock
- Dropped patches:
ef482951-apparmor-Allow-umount-dev.patch,
d6a8b9ee-qemu-Fix-managed-no-when-creating-ethdev.patch,
c3f16cea-qemu-cleanup-label-on-umount-failure.patch,
697c16e3-qemu_process-better-debug-message.patch,
5155ab4b-qemu_namespace-nested-mounts-when-umount.patch
OBS-URL: https://build.opensuse.org/request/show/1068569
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=968
2023-03-02 01:49:27 +01:00
|
|
|
@@ -1206,6 +1221,8 @@ libxlMakeDisk(virDomainDiskDef *l_disk,
|
2021-09-01 18:17:27 +02:00
|
|
|
x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0;
|
|
|
|
libxlDiskSetDiscard(x_disk, l_disk->discard);
|
2016-06-24 19:07:56 +02:00
|
|
|
libxlDiskSetCacheMode(x_disk, l_disk->cachemode);
|
2021-09-01 18:17:27 +02:00
|
|
|
+ libxlDiskSetScript(x_disk, src);
|
2016-02-23 23:12:48 +01:00
|
|
|
+
|
|
|
|
/* An empty CDROM must have the empty format, otherwise libxl fails. */
|
|
|
|
if (x_disk->is_cdrom && !x_disk->pdev_path)
|
|
|
|
x_disk->format = LIBXL_DISK_FORMAT_EMPTY;
|