SHA256
1
0
forked from pool/libvirt
libvirt/blockcopy-check-dst-identical-device.patch
James Fehlig e20ed85102 Accepting request 247245 from home:jfehlig:branches:Virtualization
- Update to libvirt 1.2.8
  - virDomainBlockCopy with XML destination, typed params
  - Introduce API for retrieving bulk domain stats
  - Introduce virDomainOpenGraphicsFD API
  - Many incremental improvements and bug fixes, see
    http://libvirt.org/news.html

OBS-URL: https://build.opensuse.org/request/show/247245
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=403
2014-09-02 15:52:40 +00:00

32 lines
1.1 KiB
Diff

From 475b272c126d53f3985860422dc96b01b470423e Mon Sep 17 00:00:00 2001
From: Chunyan Liu <cyliu@suse.com>
Date: Tue, 29 Jul 2014 17:31:28 +0800
Subject: [PATCH] blockcopy: check dst = identical device
Check whether dst is the same device as source, if yes, report
error and exit.
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
src/qemu/qemu_driver.c | 7 +++++++
1 file changed, 7 insertions(+)
Index: libvirt-1.2.8/src/qemu/qemu_driver.c
===================================================================
--- libvirt-1.2.8.orig/src/qemu/qemu_driver.c
+++ libvirt-1.2.8/src/qemu/qemu_driver.c
@@ -15357,6 +15357,13 @@ qemuDomainBlockCopy(virDomainObjPtr vm,
}
/* Prepare the destination file. */
+ if (STREQ_NULLABLE(realpath(disk->src->path, NULL), realpath(dest, NULL))) {
+ virReportError(VIR_ERR_INVALID_ARG,
+ _("destination '%s' is the same as disk '%s' source"),
+ dest, path);
+ goto endjob;
+ }
+
if (stat(dest, &st) < 0) {
if (errno != ENOENT) {
virReportSystemError(errno, _("unable to stat for disk %s: %s"),