forked from pool/libvirt
9462ef6485
- util: improvements in error handling
09877303-virSocketAddrParseInternal.patch,
412afdb8-intro-virSocketAddrParseAny.patch
bsc#1080957
- Update to libvirt 4.2.0
- Many incremental improvements and bug fixes, see
http://libvirt.org/news.html
- Dropped patches:
6b3d716e-keycodemap-py3.patch,
33c6eb96-fix-libvirtd-reload-deadlock.patch,
464889ff-rpc-aquire-ref-dispatch.patch,
c6f1d519-rpc-simplify-dispatch.patch,
06e7ebb6-rpc-invoke-dispatch-unlocked.patch,
86cae503-rpc-fix-pre-exec.patch,
eefabb38-rpc-virtlockd-virtlogd-single-thread.patch,
fbf31e1a-CVE-2018-1064.patch,
fb327ac2-virtlockd-admin-socket.patch,
64370c4b-libxl-MigrateBegin.patch,
99486799-libxl-MigrateConfirm.patch,
f5eacf2a-libxl-MigratePerform.patch,
4e6fcdb6-libxl-libxlDomObjFromDomain-cleanup.patch,
fe51dbda-libxl-use-FindByRef.patch,
60b3fcd9-libxl-MigratePrepare.patch,
3c89868c-libxl-lock-after-ListRemove.patch,
13e81fc6-libxl-EndJob-on-error.patch,
594b8b99-libxl-DefineXMLFlags-API-pattern.patch,
c66e344e-libxl-dont-deref-NULL.patch,
83edaf44-libxl-dont-hardcode-sched-weight.patch,
apibuild-py3.patch
OBS-URL: https://build.opensuse.org/request/show/593871
OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=683
52 lines
2.4 KiB
Diff
52 lines
2.4 KiB
Diff
From 15c7f9a6e7678238ef06f5d805984addb6f8bcdb Mon Sep 17 00:00:00 2001
|
|
From: Martin Wilck <mwilck@suse.com>
|
|
Date: Thu, 15 Dec 2016 10:17:05 +0100
|
|
Subject: [PATCH] network: don't use dhcp-authoritative on static networks
|
|
|
|
"Static" DHCP networks are those where no dynamic DHCP range is
|
|
defined, only a list of host entries is used to serve permanent
|
|
IP addresses. On such networks, we don't want dnsmasq to reply
|
|
to other requests than those statically defined. But
|
|
"dhcp-authoritative" will cause dnsmasq to do just that.
|
|
Therefore we can't use "dhcp-authoritative" for static networks.
|
|
|
|
Fixes: 4ac20b3ae "network: add dnsmasq option 'dhcp-authoritative'"
|
|
Signed-off-by: Martin Wilck <mwilck@suse.com>
|
|
---
|
|
src/network/bridge_driver.c | 9 ++++++++-
|
|
tests/networkxml2confdata/dhcp6host-routed-network.conf | 1 -
|
|
2 files changed, 8 insertions(+), 2 deletions(-)
|
|
|
|
Index: libvirt-4.2.0/src/network/bridge_driver.c
|
|
===================================================================
|
|
--- libvirt-4.2.0.orig/src/network/bridge_driver.c
|
|
+++ libvirt-4.2.0/src/network/bridge_driver.c
|
|
@@ -1470,7 +1470,14 @@ networkDnsmasqConfContents(virNetworkObj
|
|
if (VIR_SOCKET_ADDR_IS_FAMILY(&ipdef->address, AF_INET)) {
|
|
if (ipdef->nranges || ipdef->nhosts) {
|
|
virBufferAddLit(&configbuf, "dhcp-no-override\n");
|
|
- virBufferAddLit(&configbuf, "dhcp-authoritative\n");
|
|
+ /*
|
|
+ * Use "dhcp-authoritative" only for dynamic DHCP.
|
|
+ * In a static-only network, it would cause dnsmasq
|
|
+ * to reply to requests from other hosts than those
|
|
+ * statically defined.
|
|
+ */
|
|
+ if (ipdef->nranges || !ipdef->nhosts)
|
|
+ virBufferAddLit(&configbuf, "dhcp-authoritative\n");
|
|
}
|
|
|
|
if (ipdef->tftproot) {
|
|
Index: libvirt-4.2.0/tests/networkxml2confdata/dhcp6host-routed-network.conf
|
|
===================================================================
|
|
--- libvirt-4.2.0.orig/tests/networkxml2confdata/dhcp6host-routed-network.conf
|
|
+++ libvirt-4.2.0/tests/networkxml2confdata/dhcp6host-routed-network.conf
|
|
@@ -10,7 +10,6 @@ bind-dynamic
|
|
interface=virbr1
|
|
dhcp-range=192.168.122.1,static
|
|
dhcp-no-override
|
|
-dhcp-authoritative
|
|
dhcp-range=2001:db8:ac10:fd01::1,static,64
|
|
dhcp-hostsfile=/var/lib/libvirt/dnsmasq/local.hostsfile
|
|
addn-hosts=/var/lib/libvirt/dnsmasq/local.addnhosts
|