forked from pool/libvirt
e0ef76a77b
- bnc#820399 - virsh blockcopy should refuse identical device blockcopy-check-dst-identical-device.patch OBS-URL: https://build.opensuse.org/request/show/243931 OBS-URL: https://build.opensuse.org/package/show/Virtualization/libvirt?expand=0&rev=396
32 lines
1.1 KiB
Diff
32 lines
1.1 KiB
Diff
From 475b272c126d53f3985860422dc96b01b470423e Mon Sep 17 00:00:00 2001
|
|
From: Chunyan Liu <cyliu@suse.com>
|
|
Date: Tue, 29 Jul 2014 17:31:28 +0800
|
|
Subject: [PATCH] blockcopy: check dst = identical device
|
|
|
|
Check whether dst is the same device as source, if yes, report
|
|
error and exit.
|
|
|
|
Signed-off-by: Chunyan Liu <cyliu@suse.com>
|
|
---
|
|
src/qemu/qemu_driver.c | 7 +++++++
|
|
1 file changed, 7 insertions(+)
|
|
|
|
Index: libvirt-1.2.5/src/qemu/qemu_driver.c
|
|
===================================================================
|
|
--- libvirt-1.2.5.orig/src/qemu/qemu_driver.c
|
|
+++ libvirt-1.2.5/src/qemu/qemu_driver.c
|
|
@@ -15263,6 +15263,13 @@ qemuDomainBlockCopy(virDomainObjPtr vm,
|
|
}
|
|
|
|
/* Prepare the destination file. */
|
|
+ if (STREQ_NULLABLE(realpath(disk->src->path, NULL), realpath(dest, NULL))) {
|
|
+ virReportError(VIR_ERR_INVALID_ARG,
|
|
+ _("destination '%s' is the same as disk '%s' source"),
|
|
+ dest, path);
|
|
+ goto endjob;
|
|
+ }
|
|
+
|
|
if (stat(dest, &st) < 0) {
|
|
if (errno != ENOENT) {
|
|
virReportSystemError(errno, _("unable to stat for disk %s: %s"),
|