mdadm/0001-mdmon-.service-Change-type-of-process-start-up-to-fo.patch

From 2167de78aab599e7a7a8d057ef04bf18527bc129 Mon Sep 17 00:00:00 2001
From: Pawel Baldysiak <pawel.baldysiak@intel.com>
Date: Thu, 6 Mar 2014 15:51:44 +0100
Subject: [PATCH 1/6] mdmon@.service: Change type of process start-up to
 'forking'.

Mdadm does not wait enough time when mdmon is started by systemd.
It causes various problems with behaviour of a RAID volume with external metadata.
For example: mdmon does not update a value of checkpoint during migration
and second RAID5 volume is read-only after reboot done during
container reshape (both problems occur with IMSM matadata).
If a type of process start-up is changed to 'forking', systemctl will
wait until mdmon (parent) process exits after calling fork.
This way mdmon will always be fully initialized after start_mdmon
and these problems will not occur.
In this case it is recommended to add a path to PIDFile, so that systemd
does not have to guess a PID of the mdmon process.

Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---
 systemd/mdmon@.service | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/systemd/mdmon@.service b/systemd/mdmon@.service
index 5520cd03137c..304b26e890c7 100644
--- a/systemd/mdmon@.service
+++ b/systemd/mdmon@.service
@@ -14,5 +14,7 @@ Before=initrd-switch-root.target
 # mdmon should never complain due to lack of a platform,
 # that is mdadm's job if at all.
 Environment=IMSM_NO_PLATFORM=1
-ExecStart=/sbin/mdmon --foreground %I
+ExecStart=/sbin/mdmon %I
+Type=forking
+PIDFile=/run/mdadm/%I.pid
 KillMode=none
-- 
1.8.3.1.487.g3e7a5b4
- 0001-DDF-mark-missing-on-assembly-device-properly.patch - 0002-DDF-guard-against-pdnum-being-negative.patch - 0003-DDF-fix-possible-mdmon-crash-when-updating-metadata.patch - 0004-DDF-Don-t-fail-compare_super_ddf-due-to-re-configure.patch More upstream DDF fixes (bnc#866660) - 0001-mdmon-.service-Change-type-of-process-start-up-to-fo.patch - 0003-Work-around-architectures-having-statfs.f_type-defin.patch - 0004-DDF-report-seq-counter-as-events.patch - 0005-DDF-when-first-activating-an-array-record-any-missin.patch Two fixes for DDF (bnc#866660) and a couple of other upstream fixes just for good measure. - 0001-Assemble-allow-load_devices-to-change-the-st-which-i.patch 0002-Assemble-re-arrange-freeing-of-tst-in-load_devices.patch 0003-Assemble-change-load_devices-to-return-most_recent-s.patch Allow RAID5 to be assembled even when firs device listed recently failed (bnc#865221) OBS-URL: https://build.opensuse.org/package/show/Base:System/mdadm?expand=0&rev=105 2014-04-02 08:19:16 +02:00			`From 2167de78aab599e7a7a8d057ef04bf18527bc129 Mon Sep 17 00:00:00 2001`
			`From: Pawel Baldysiak <pawel.baldysiak@intel.com>`
			`Date: Thu, 6 Mar 2014 15:51:44 +0100`
			`Subject: [PATCH 1/6] mdmon@.service: Change type of process start-up to`
			`'forking'.`

			`Mdadm does not wait enough time when mdmon is started by systemd.`
			`It causes various problems with behaviour of a RAID volume with external metadata.`
			`For example: mdmon does not update a value of checkpoint during migration`
			`and second RAID5 volume is read-only after reboot done during`
			`container reshape (both problems occur with IMSM matadata).`
			`If a type of process start-up is changed to 'forking', systemctl will`
			`wait until mdmon (parent) process exits after calling fork.`
			`This way mdmon will always be fully initialized after start_mdmon`
			`and these problems will not occur.`
			`In this case it is recommended to add a path to PIDFile, so that systemd`
			`does not have to guess a PID of the mdmon process.`

			`Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>`
			`Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>`
			`Reviewed-by: Lukasz Dorau <lukasz.dorau@intel.com>`
			`Signed-off-by: NeilBrown <neilb@suse.de>`
			`---`
			`systemd/mdmon@.service \| 4 +++-`
			`1 file changed, 3 insertions(+), 1 deletion(-)`

			`diff --git a/systemd/mdmon@.service b/systemd/mdmon@.service`
			`index 5520cd03137c..304b26e890c7 100644`
			`--- a/systemd/mdmon@.service`
			`+++ b/systemd/mdmon@.service`
			`@@ -14,5 +14,7 @@ Before=initrd-switch-root.target`
			`# mdmon should never complain due to lack of a platform,`
			`# that is mdadm's job if at all.`
			`Environment=IMSM_NO_PLATFORM=1`
			`-ExecStart=/sbin/mdmon --foreground %I`
			`+ExecStart=/sbin/mdmon %I`
			`+Type=forking`
			`+PIDFile=/run/mdadm/%I.pid`
			`KillMode=none`
			`--`
			`1.8.3.1.487.g3e7a5b4`