forked from pool/munin
Aeneas Jaißle
40db143d15
- fix CVE-2017-6188: munin-cgi-graph local file write vulnerability (boo#1026539, CVE-2017-6188-fix-parameter-injection.patch) - update to version 2.0.30 Bugfix releases (closes the following issues since 2.0.25) 2.0.26: Closes: D:761190, GH:426 2.0.27: Closes: D:767032, D:768553, D:825136, D:834194, GH:690, GH:714 2.0.29: Closes: D:847649, D:849383 2.0.30: Closes: GH:745, GH:771, GH:783 OBS-URL: https://build.opensuse.org/request/show/460029 OBS-URL: https://build.opensuse.org/package/show/server:monitoring/munin?expand=0&rev=29
30 lines
1.3 KiB
Diff
30 lines
1.3 KiB
Diff
From: Tomaž Šolc <tomaz.solc@tablix.org>
|
|
Date: Tue, 21 Feb 2017 14:42:26 +0100
|
|
Subject: CVE-2017-6188: munin-cgi-graph local file write vulnerability
|
|
References: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855705
|
|
boo#1026539
|
|
Upstream: https://github.com/munin-monitoring/munin/issues/721
|
|
|
|
Index: munin-2.0.25/master/_bin/munin-cgi-graph.in
|
|
===================================================================
|
|
--- munin-2.0.25.orig/master/_bin/munin-cgi-graph.in
|
|
+++ munin-2.0.25/master/_bin/munin-cgi-graph.in
|
|
@@ -447,13 +447,13 @@ sub draw_graph {
|
|
'--output-file', $filename );
|
|
|
|
# Sets the correct size on a by_graph basis
|
|
- push @params, "--size_x", CGI::param("size_x")
|
|
+ push @params, "--size_x", scalar CGI::param("size_x")
|
|
if (defined(CGI::param("size_x")));
|
|
- push @params, "--size_y", CGI::param("size_y")
|
|
+ push @params, "--size_y", scalar CGI::param("size_y")
|
|
if (defined(CGI::param("size_y")));
|
|
- push @params, "--upper_limit", CGI::param("upper_limit")
|
|
+ push @params, "--upper_limit", scalar CGI::param("upper_limit")
|
|
if (CGI::param("upper_limit"));
|
|
- push @params, "--lower_limit", CGI::param("lower_limit")
|
|
+ push @params, "--lower_limit", scalar CGI::param("lower_limit")
|
|
if (CGI::param("lower_limit"));
|
|
|
|
# Sometimes we want to set the IMG size, and not the canvas.
|