forked from pool/openafs
cfa65eea8c
- update to openafs-1.8.11 - apply upstream patches for kernel 6.8 * 056a7a8.diff * 05ac614.diff * 073adec.diff * 0d9f6cf.diff * 0e983a9.diff * 112fb94.diff * 1e1bf8e.diff * 2056ce8.diff * 5312d06.diff * 67e48c8.diff * 6b20756.diff * 743d72f.diff * 7cae97b.diff * 81b910a.diff * 87ab04a.diff * 9f052c1.diff * a14a9ad.diff * a87845d.diff * aae8b00.diff * b77b304.diff * d1c89ac.diff * d9f3a2c.diff * db91384.diff * dffd0e1.diff * e0f425a.diff * e157f8f.diff * e428053.diff * ef7b8c5.diff * f5bafb0.diff * fca6fd9.diff OBS-URL: https://build.opensuse.org/request/show/1170220 OBS-URL: https://build.opensuse.org/package/show/filesystems/openafs?expand=0&rev=123
53 lines
1.9 KiB
Diff
53 lines
1.9 KiB
Diff
From 9f052c137d1184a783c8ac3182c3544b275484f5 Mon Sep 17 00:00:00 2001
|
|
From: Andrew Deason <adeason@sinenomine.net>
|
|
Date: Sat, 09 Jan 2021 12:50:03 -0600
|
|
Subject: [PATCH] afs: Remove SRXAFSCB_GetDE
|
|
|
|
The GetDE RPC has been commented out from afscbint.xg effectively
|
|
since it was introduced, but we still define the SRXAFSCB_GetDE server
|
|
stub for it.
|
|
|
|
This is useless, but also potentially dangerous, since the stub
|
|
routine just returns success, without populating the output arguments.
|
|
One of the output arguments is a string, and so if this RPC is
|
|
actually run, the rxgen-generated server code will try to xdr_string()
|
|
that string. Since we never set it to anything, this will result in
|
|
xdr_string trying to dereference a NULL pointer.
|
|
|
|
None of this actually happens currently, since the GetDE RPC is
|
|
commented out. But to avoid the above situation if it's ever
|
|
uncommented, remove the useless SRXAFSCB_GetDE function.
|
|
|
|
Reviewed-on: https://gerrit.openafs.org/14488
|
|
Tested-by: BuildBot <buildbot@rampaginggeek.com>
|
|
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
|
|
(cherry picked from commit 444a971edc47c34efbefed6e332ee6e843ae072b)
|
|
|
|
Change-Id: I83846d79ce3143571923cb6023075620091f093d
|
|
Reviewed-on: https://gerrit.openafs.org/15681
|
|
Tested-by: BuildBot <buildbot@rampaginggeek.com>
|
|
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
|
|
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
|
|
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
|
|
---
|
|
|
|
diff --git a/src/afs/afs_callback.c b/src/afs/afs_callback.c
|
|
index e7d8ab5..22edefb 100644
|
|
--- a/src/afs/afs_callback.c
|
|
+++ b/src/afs/afs_callback.c
|
|
@@ -1636,14 +1636,3 @@
|
|
|
|
return code;
|
|
}
|
|
-
|
|
-
|
|
-int
|
|
-SRXAFSCB_GetDE(struct rx_call *a_call, afs_int32 a_index, afs_int32 *addr,
|
|
- afs_int32 *inode, afs_int32 *flags, afs_int32 *time,
|
|
- char ** fileName)
|
|
-{ /*SRXAFSCB_GetDE*/
|
|
- int code = 0; /*Return code*/
|
|
- return(code);
|
|
-
|
|
-} /*SRXAFSCB_GetDE*/
|