Accepting request 1247231 from science:HPC

OBS-URL: https://build.opensuse.org/request/show/1247231
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/openmpi4?expand=0&rev=19

Fix-type-mismatch-error.patch

@@ -0,0 +1,30 @@
+commit fc4fb3a80615992277717e3e29ce585ebe1f2256
+Author: Tomislav Janjusic <tomislavj@nvidia.com>
+Date:   Tue Feb 18 12:25:27 2025 -0600
+
+    Fix type mismatch error
+    
+    Signed-off-by: Tomislav Janjusic <tomislavj@nvidia.com>
+
+diff --git oshmem/mca/sshmem/base/sshmem_base_open.c oshmem/mca/sshmem/base/sshmem_base_open.c
+index 1f0d1eb761e2..2694120e1cfe 100644
+--- oshmem/mca/sshmem/base/sshmem_base_open.c
++++ oshmem/mca/sshmem/base/sshmem_base_open.c
+@@ -31,7 +31,7 @@
+  * globals
+  */
+ 
+-void *mca_sshmem_base_start_address = UINTPTR_MAX;
++void *mca_sshmem_base_start_address = (void *)UINTPTR_MAX;
+ 
+ char * mca_sshmem_base_backing_file_dir = NULL;
+ 
+@@ -49,7 +49,7 @@ mca_sshmem_base_register (mca_base_register_flag_t flags)
+                                  "base",
+                                  "start_address",
+                                  "Specify base address for shared memory region",
+-                                 MCA_BASE_VAR_TYPE_UNSIGNED_LONG_LONG,
++                                 MCA_BASE_VAR_TYPE_UNSIGNED_LONG,
+                                  NULL,
+                                  0,
+                                  MCA_BASE_VAR_FLAG_SETTABLE,

_service

@@ -1,5 +1,5 @@
 <services>
-  <service name="tar_scm" mode="disabled">
+  <service name="tar_scm" mode="manual">
     <param name="scm">git</param>
     <param name="url">https://github.com/open-mpi/ompi.git</param>
     <param name="package-meta">no</param>
@@ -8,9 +8,9 @@
     <param name="versionformat">@PARENT_TAG@.@TAG_OFFSET@.%h</param>
     <param name="versionrewrite-pattern">v(.*)</param>
     <param name="versionrewrite-replacement">\1</param>
-    <param name="revision">439b23db6288f0370f6fcc80c8c0a06ad86d6873</param>
+    <param name="revision">ea8f4d03089018f08451f42f2cfa2467570f395e</param>
   </service>
-  <service name="recompress" mode="disabled">
+  <service name="recompress" mode="manual">
     <param name="file">openmpi*.tar</param>
     <param name="compression">bz2</param>
   </service>

mtl-ofi-fix-missing-definition-of-container_of.patch

@@ -0,0 +1,24 @@
+commit 75b6dad5959ba75fcba8c64cc0a364d820e03ebc
+Author: Nicolas Morey <nmorey@suse.com>
+Date:   Fri Dec 20 12:44:38 2024 +0100
+
+    mtl: ofi: fix missing definition of container_of
+    
+    Signed-off-by: Nicolas Morey <nmorey@suse.com>
+
+diff --git ompi/mca/mtl/ofi/mtl_ofi_request.h ompi/mca/mtl/ofi/mtl_ofi_request.h
+index f68c2a91baa0..6d748fd59bdc 100644
+--- ompi/mca/mtl/ofi/mtl_ofi_request.h
++++ ompi/mca/mtl/ofi/mtl_ofi_request.h
+@@ -15,6 +15,11 @@
+ 
+ #include "mtl_ofi.h"
+ 
++#ifndef container_of
++#define container_of(ptr, type, field) \
++        ((type *) ((char *)ptr - offsetof(type, field)))
++#endif
++
+ #define TO_OFI_REQ(_ptr_ctx) \
+     container_of((_ptr_ctx), struct ompi_mtl_ofi_request_t, ctx)
+ 

openmpi4.changes

@@ -1,3 +1,56 @@
+-------------------------------------------------------------------
+Wed Feb 19 16:04:48 UTC 2025 - Nicolas Morey <nicolas.morey@suse.com>
+
+- Update to 4.1.8 (jsc#PED-11356):
+  - Allocate and exchange OpenSHMEM base segment addresses earlier in
+    startup.
+  - Fixed file_seek calculation when using SEEK_END and io/ompio.
+  - Protect against using CUDA without VMM support.
+  - Change several variables in coll/adapt, coll/basic, coll/han,
+    coll/hcoll, and coll/ucc from READONLY to ALL scope so that they can
+    be set via the MPI_T interface.
+  - Add version identifier to rules file in coll/tuned and extend the
+    dynamic rules file to support the alltoall_algorithm_max_requests
+    tuning parameter.
+- Change default openmpi to openmpi5 for suse_version >= 1600
+- Add Fix-type-mismatch-error.patch to fix a compilation error
+
+-------------------------------------------------------------------
+Fri Dec 20 11:46:32 UTC 2024 - Nicolas Morey <nicolas.morey@suse.com>
+
+- Add mtl-ofi-fix-missing-definition-of-container_of.patch to fix
+ compilation with libfabric >= 2.0 (jsc#PED-9661, jsc#PED-10668)
+
+-------------------------------------------------------------------
+Tue Nov 26 07:12:00 UTC 2024 - Nicolas Morey <nicolas.morey@suse.com>
+
+- Update to 4.1.7 (jsc#PED-11355):
+  - Fix int overflow bug in UCC collectives routine, which would impact
+    large message collectives.
+  - Fix SHMEM bounds checking warnings
+  - Fix memory leak in the fcoll/vulcan component
+  - Fix memory leak when using non-contiguious datatyles with pml/cm
+    (used when using Libfabric or Portals transports)
+  - Change default locking protocol for ufs IO component to fix data
+    sieving use case.
+  - Fix bug in Fortran / C interface array calculation.
+  - Fix potential initialization in UCX OpenSHMEM support
+  - Add OpenSHMEM support for symmetric remote key handling to improve
+    scalability of OpenSHMEM interface.
+  - Add MCS Locks as default implementation for OpenSHMEM locks.
+  - Fix bug to properly handle ORTE Prefix of "/".
+  - Fix bug in I/O interface handling of soft links on Lustre
+    filesystems.
+  - Fix memory leak in UCX one-sided implementation.
+  - Fix bug in rcache components that could lead to assert on macOS
+    systems.
+  - Fix mishandling of a NULL completion context in the OFI transport.
+  - Tarballs are now built with the tar-pax format.
+  - Set MPI_THREAD_SERIALIZED instead of MPI_THREAD_SINGLE as supported
+    threading model when using UCX that supports
+    UCS_THREAD_MODE_SERIALIZED.
+  - Fix issue that would prevent using Libfabric 2.x releases.
+
 -------------------------------------------------------------------
 Thu Sep  5 06:58:41 UTC 2024 - Nicolas Morey <nicolas.morey@suse.com>
 

openmpi4.spec

@@ -1,7 +1,7 @@
 #
 # spec file
 #
-# Copyright (c) 2024 SUSE LLC
+# Copyright (c) 2025 SUSE LLC
 # Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
 #                         University Research and Technology
 #                         Corporation.  All rights reserved.
@@ -42,7 +42,7 @@
 # % define build_static_devel 1
 
 %global pname openmpi
-%define _vers 4_1_6
+%define _vers 4_1_8
 %define m_f_ver 4
 %bcond_with ringdisabled
 
@@ -103,7 +103,7 @@ ExclusiveArch:  do_not_build
 %endif
 
 # Detect whether we are the default openMPI implemantation or not
-%if "%{flavor}" == "standard" && (%{suse_version} > 1500 || 0%{?sle_version} > 150300)
+%if "%{flavor}" == "standard" && (%{suse_version} > 1500 || 0%{?sle_version} > 150300) &&  (%{suse_version} < 1600)
 %define default_openmpi 1
 %else
 %define default_openmpi 0
@@ -124,7 +124,7 @@ ExcludeArch:    i586 %arm s390
 %{bcond_with hwloc}
 %endif
 
-%define git_ver .0.439b23db6288
+%define git_ver .0.ea8f4d030890
 
 #############################################################################
 #
@@ -133,7 +133,7 @@ ExcludeArch:    i586 %arm s390
 #############################################################################
 
 Name:           %{package_name}%{?testsuite:-testsuite}
-Version:        4.1.6
+Version:        4.1.8
 Release:        0
 Summary:        An implementation of MPI/SHMEM (Version %{m_f_ver})
 License:        BSD-3-Clause
@@ -148,6 +148,8 @@ Patch1:         orted-mpir-add-version-to-shared-library.patch
 Patch2:         btl-openib-Add-VF-support-for-ConnectX-4-5-and-6.patch
 Patch3:         openmpi4-C99.diff
 Patch4:         test-datatype-partial.c-fix-compiler-warnings.patch
+Patch5:         mtl-ofi-fix-missing-definition-of-container_of.patch
+Patch6:         Fix-type-mismatch-error.patch
 Provides:       mpi
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 BuildRequires:  autoconf