- Add --askpass to ExecStart, so that the user name and password

are correctly being queried from the user.
  (bsc#1078026, boo#985798, boo#1031748)
- Use %service_add/del macros throughout (bsc#1038406).

OBS-URL: https://build.opensuse.org/package/show/network:vpn/openvpn?expand=0&rev=131

openvpn.changes

@@ -1,3 +1,11 @@
+-------------------------------------------------------------------
+Tue Feb 13 17:49:09 UTC 2018 - max@suse.com
+
+- Add --askpass to ExecStart, so that the user name and password
+  are correctly being queried from the user.
+  (bsc#1078026, boo#985798, boo#1031748)
+- Use %service_add/del macros throughout (bsc#1038406).
+
 -------------------------------------------------------------------
 Thu Nov 23 13:52:15 UTC 2017 - rbrown@suse.com
 

openvpn.service

@@ -7,7 +7,7 @@ PartOf=openvpn.target
 Type=forking
 PrivateTmp=true
 PIDFile=/var/run/openvpn/%i.pid
-ExecStart=/usr/sbin/openvpn --daemon --suppress-timestamps --writepid /var/run/openvpn/%i.pid --cd /etc/openvpn/ --config %i.conf
+ExecStart=/usr/sbin/openvpn --daemon --askpass --suppress-timestamps --writepid /var/run/openvpn/%i.pid --cd /etc/openvpn/ --config %i.conf
 ExecReload=/sbin/killproc -p /var/run/openvpn/%i.pid -HUP /usr/sbin/openvpn
 
 [Install]

openvpn.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package openvpn
 #
-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -211,6 +211,9 @@ install -m 755 $RPM_SOURCE_DIR/client-netconfig.down sample/sample-scripts/clien
 rm -rf %{buildroot}%{_datadir}/doc/{OpenVPN,%{name}}
 find sample -name .gitignore | xargs rm -f
 
+%pre
+%service_add_pre %{name}.target
+
 %post
 %if %{with_systemd}
 systemd-tmpfiles --create %{_tmpfilesdir}/%{name}.conf ||:
@@ -262,7 +265,7 @@ rm -f %{_sysconfdir}/sysconfig/openvpn || :
 
 %postun
 %if %{with_systemd}
-/bin/systemctl --system daemon-reload &>/dev/null || :
+%service_del_postun %{name}.target
 %else
 %{?insserv_cleanup:%insserv_cleanup}
 %endif