From cc51a80b55899bb0aa6f3c8fe796549159fcfa4709b8989a31503f6057236734 Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger Date: Fri, 24 Jul 2020 08:42:53 +0000 Subject: [PATCH] Accepting request 821865 from GNOME:Next OBS-URL: https://build.opensuse.org/request/show/821865 OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/polari?expand=0&rev=106 --- polari-fix-log-spam.patch | 45 +++++++++++++++++++++++++++++++++++++++ polari.changes | 5 +++++ polari.spec | 2 ++ 3 files changed, 52 insertions(+) create mode 100644 polari-fix-log-spam.patch diff --git a/polari-fix-log-spam.patch b/polari-fix-log-spam.patch new file mode 100644 index 0000000..1dae724 --- /dev/null +++ b/polari-fix-log-spam.patch @@ -0,0 +1,45 @@ +From eb918032722041abaed5f74a37a091e322e2d319 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Florian=20M=C3=BCllner?= +Date: Sat, 18 Jul 2020 16:12:25 +0200 +Subject: [PATCH] urlPreview: Move margin into CSS + +Setting it in code for some reason confuses size negotiations, resulting +in warnings about negative size requests. It looks like CSS margins +don't suffer from the same problem, so just use those instead. + +https://gitlab.gnome.org/GNOME/polari/-/issues/142 +--- + data/resources/application.css | 3 +++ + src/urlPreview.js | 2 -- + 2 files changed, 3 insertions(+), 2 deletions(-) + +diff --git a/data/resources/application.css b/data/resources/application.css +index a0a57a76..e455304f 100644 +--- a/data/resources/application.css ++++ b/data/resources/application.css +@@ -118,6 +118,9 @@ treeview.polari-server-room-list { + } + + .url-preview { padding: 8px; } ++.url-preview { margin: 12px; } ++.url-preview:dir(ltr) { margin-left: 0; } ++.url-preview:dir(rtl) { margin-right: 0; } + .url-preview image { min-width: 120px; min-height: 90px; } + .url-preview label { font-size: small; } + +diff --git a/src/urlPreview.js b/src/urlPreview.js +index e388b78b..b818c812 100644 +--- a/src/urlPreview.js ++++ b/src/urlPreview.js +@@ -78,8 +78,6 @@ var URLPreview = GObject.registerClass({ + + this.set({ + orientation: Gtk.Orientation.VERTICAL, +- margin: 12, +- margin_start: 0, + spacing: 6, + }); + +-- +GitLab + diff --git a/polari.changes b/polari.changes index 01e044e..a6e9d18 100644 --- a/polari.changes +++ b/polari.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Sat Jul 18 19:15:46 UTC 2020 - Bjørn Lie + +- Add polari-fix-log-spam.patch: Quiet down unneeded warnings. + ------------------------------------------------------------------- Wed Jun 3 16:34:04 UTC 2020 - Bjørn Lie diff --git a/polari.spec b/polari.spec index 4390a50..41153f5 100644 --- a/polari.spec +++ b/polari.spec @@ -28,6 +28,8 @@ Source0: https://download.gnome.org/sources/polari/3.36/%{name}-%{version Source99: polari-rpmlintrc # PATCH-FIX-UPSTREAM polari-fix-nb-translation.patch glgo#GNOME/polari!145 -- Fix Norwegian bokmål translation Patch0: polari-fix-nb-translation.patch +# PATCH-FIX-UPSTREAM polari-fix-log-spam.patch -- Quiet down unneeded log warnings +Patch1: polari-fix-log-spam.patch BuildRequires: gjs >= 1.57.3 BuildRequires: meson >= 0.43.0