2018-08-22 16:58:18 +02:00
|
|
|
From 780702171c0213af1594a9ba8a0756073ded5f49 Mon Sep 17 00:00:00 2001
|
2018-07-05 22:55:09 +02:00
|
|
|
From: Bruce Rogers <brogers@suse.com>
|
|
|
|
Date: Fri, 8 Jun 2018 11:04:36 -0600
|
|
|
|
Subject: [PATCH] xen: add block resize support for xen disks
|
|
|
|
|
|
|
|
Provide monitor naming of xen disks, and plumb guest driver
|
|
|
|
notification through xenstore of resizing instigated via the
|
|
|
|
monitor.
|
|
|
|
|
|
|
|
Signed-off-by: Bruce Rogers <brogers@suse.com>
|
|
|
|
---
|
|
|
|
block/block-backend.c | 12 +++++++++++-
|
|
|
|
blockdev.c | 8 ++++++++
|
|
|
|
hw/block/xen_disk.c | 24 ++++++++++++++++++++++++
|
|
|
|
include/hw/xen/xen.h | 4 ++++
|
2018-08-22 16:58:18 +02:00
|
|
|
include/sysemu/block-backend.h | 1 +
|
2018-07-05 22:55:09 +02:00
|
|
|
stubs/xen-common.c | 9 +++++++++
|
2018-08-22 16:58:18 +02:00
|
|
|
6 files changed, 57 insertions(+), 1 deletion(-)
|
2018-07-05 22:55:09 +02:00
|
|
|
|
|
|
|
diff --git a/block/block-backend.c b/block/block-backend.c
|
2018-08-22 16:58:18 +02:00
|
|
|
index f2f75a977d..f62217d967 100644
|
2018-07-05 22:55:09 +02:00
|
|
|
--- a/block/block-backend.c
|
|
|
|
+++ b/block/block-backend.c
|
|
|
|
@@ -23,6 +23,7 @@
|
|
|
|
#include "qemu/option.h"
|
|
|
|
#include "trace.h"
|
|
|
|
#include "migration/misc.h"
|
|
|
|
+#include "hw/xen/xen.h"
|
|
|
|
|
|
|
|
/* Number of coroutines to reserve per attached device model */
|
|
|
|
#define COROUTINE_POOL_RESERVATION 64
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -900,7 +901,9 @@ char *blk_get_attached_dev_id(BlockBackend *blk)
|
2018-07-05 22:55:09 +02:00
|
|
|
{
|
|
|
|
DeviceState *dev;
|
|
|
|
|
|
|
|
- assert(!blk->legacy_dev);
|
|
|
|
+ if (blk->legacy_dev) {
|
|
|
|
+ return xen_blk_get_attached_dev_id(blk->dev);
|
|
|
|
+ }
|
|
|
|
dev = blk->dev;
|
|
|
|
|
|
|
|
if (!dev) {
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -2005,6 +2008,13 @@ int blk_truncate(BlockBackend *blk, int64_t offset, PreallocMode prealloc,
|
2018-07-05 22:55:09 +02:00
|
|
|
return bdrv_truncate(blk->root, offset, prealloc, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
+void blk_legacy_resize_cb(BlockBackend *blk)
|
|
|
|
+{
|
|
|
|
+ if (blk->legacy_dev) {
|
|
|
|
+ xen_blk_resize_cb(blk->dev);
|
|
|
|
+ }
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
static void blk_pdiscard_entry(void *opaque)
|
|
|
|
{
|
|
|
|
BlkRwCo *rwco = opaque;
|
|
|
|
diff --git a/blockdev.c b/blockdev.c
|
2018-08-22 16:58:18 +02:00
|
|
|
index dcf8c8d2ab..bf1b82539c 100644
|
2018-07-05 22:55:09 +02:00
|
|
|
--- a/blockdev.c
|
|
|
|
+++ b/blockdev.c
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -3175,6 +3175,7 @@ void qmp_block_resize(bool has_device, const char *device,
|
2018-07-05 22:55:09 +02:00
|
|
|
{
|
|
|
|
Error *local_err = NULL;
|
|
|
|
BlockBackend *blk = NULL;
|
|
|
|
+ BlockBackend *cb_blk = NULL;
|
|
|
|
BlockDriverState *bs;
|
|
|
|
AioContext *aio_context;
|
|
|
|
int ret;
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -3187,6 +3188,10 @@ void qmp_block_resize(bool has_device, const char *device,
|
2018-07-05 22:55:09 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
+ if (has_device) {
|
|
|
|
+ cb_blk = blk_by_name(device);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
|
|
aio_context_acquire(aio_context);
|
|
|
|
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -3213,6 +3218,9 @@ void qmp_block_resize(bool has_device, const char *device,
|
2018-07-05 22:55:09 +02:00
|
|
|
|
|
|
|
bdrv_drained_begin(bs);
|
|
|
|
ret = blk_truncate(blk, size, PREALLOC_MODE_OFF, errp);
|
|
|
|
+ if (!ret && cb_blk) {
|
|
|
|
+ blk_legacy_resize_cb(cb_blk);
|
|
|
|
+ }
|
|
|
|
bdrv_drained_end(bs);
|
|
|
|
|
|
|
|
out:
|
|
|
|
diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
|
2018-08-22 16:58:18 +02:00
|
|
|
index 2b56c5e868..a90df967a3 100644
|
2018-07-05 22:55:09 +02:00
|
|
|
--- a/hw/block/xen_disk.c
|
|
|
|
+++ b/hw/block/xen_disk.c
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -759,6 +759,7 @@ static int blk_connect(struct XenDevice *xendev)
|
|
|
|
int order, ring_ref;
|
2018-07-05 22:55:09 +02:00
|
|
|
unsigned int ring_size, max_grants;
|
|
|
|
unsigned int i;
|
|
|
|
+ Error *errp = NULL;
|
|
|
|
|
|
|
|
trace_xen_disk_connect(xendev->name);
|
|
|
|
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -818,6 +819,13 @@ static int blk_connect(struct XenDevice *xendev)
|
2018-07-05 22:55:09 +02:00
|
|
|
blk_ref(blkdev->blk);
|
|
|
|
}
|
|
|
|
blk_attach_dev_legacy(blkdev->blk, blkdev);
|
|
|
|
+ if (!monitor_add_blk(blkdev->blk, g_strdup(blkdev->dev), &errp)) {
|
|
|
|
+ xen_pv_printf(&blkdev->xendev, 0, "error: %s\n",
|
|
|
|
+ error_get_pretty(errp));
|
|
|
|
+ error_free(errp);
|
|
|
|
+ return -1;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
blkdev->file_size = blk_getlength(blkdev->blk);
|
|
|
|
if (blkdev->file_size < 0) {
|
|
|
|
BlockDriverState *bs = blk_bs(blkdev->blk);
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -968,6 +976,7 @@ static void blk_disconnect(struct XenDevice *xendev)
|
2018-07-05 22:55:09 +02:00
|
|
|
if (blkdev->blk) {
|
|
|
|
blk_set_aio_context(blkdev->blk, qemu_get_aio_context());
|
|
|
|
blk_detach_dev(blkdev->blk, blkdev);
|
|
|
|
+ monitor_remove_blk(blkdev->blk);
|
|
|
|
blk_unref(blkdev->blk);
|
|
|
|
blkdev->blk = NULL;
|
|
|
|
}
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -1015,6 +1024,21 @@ static void blk_event(struct XenDevice *xendev)
|
2018-07-05 22:55:09 +02:00
|
|
|
qemu_bh_schedule(blkdev->bh);
|
|
|
|
}
|
|
|
|
|
|
|
|
+void xen_blk_resize_cb(void *dev)
|
|
|
|
+{
|
|
|
|
+ struct XenBlkDev *blkdev = dev;
|
|
|
|
+ blkdev->file_size = blk_getlength(blkdev->blk);
|
|
|
|
+ xenstore_write_be_int64(&blkdev->xendev, "sectors",
|
|
|
|
+ blkdev->file_size / blkdev->file_blk);
|
|
|
|
+ xen_be_set_state(&blkdev->xendev, blkdev->xendev.be_state);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+char *xen_blk_get_attached_dev_id(void *dev)
|
|
|
|
+{
|
|
|
|
+ struct XenBlkDev *blkdev = dev;
|
|
|
|
+ return g_strdup_printf("xen-qdisk-%i", blkdev->xendev.dev);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
struct XenDevOps xen_blkdev_ops = {
|
2018-08-22 16:58:18 +02:00
|
|
|
.flags = DEVOPS_FLAG_NEED_GNTDEV,
|
2018-07-05 22:55:09 +02:00
|
|
|
.size = sizeof(struct XenBlkDev),
|
|
|
|
diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
|
|
|
|
index 7efcdaa8fe..45c8c0b6f7 100644
|
|
|
|
--- a/include/hw/xen/xen.h
|
|
|
|
+++ b/include/hw/xen/xen.h
|
|
|
|
@@ -48,4 +48,8 @@ void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length);
|
|
|
|
|
|
|
|
void xen_register_framebuffer(struct MemoryRegion *mr);
|
|
|
|
|
|
|
|
+void xen_blk_resize_cb(void *dev);
|
|
|
|
+
|
|
|
|
+char *xen_blk_get_attached_dev_id(void *dev);
|
|
|
|
+
|
|
|
|
#endif /* QEMU_HW_XEN_H */
|
|
|
|
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
|
2018-08-22 16:58:18 +02:00
|
|
|
index 830d873f24..5ac2638d63 100644
|
2018-07-05 22:55:09 +02:00
|
|
|
--- a/include/sysemu/block-backend.h
|
|
|
|
+++ b/include/sysemu/block-backend.h
|
2018-08-22 16:58:18 +02:00
|
|
|
@@ -236,5 +236,6 @@ int coroutine_fn blk_co_copy_range(BlockBackend *blk_in, int64_t off_in,
|
|
|
|
BlockBackend *blk_out, int64_t off_out,
|
|
|
|
int bytes, BdrvRequestFlags read_flags,
|
|
|
|
BdrvRequestFlags write_flags);
|
2018-07-05 22:55:09 +02:00
|
|
|
+void blk_legacy_resize_cb(BlockBackend *blk);
|
2018-08-22 16:58:18 +02:00
|
|
|
|
2018-07-05 22:55:09 +02:00
|
|
|
#endif
|
|
|
|
diff --git a/stubs/xen-common.c b/stubs/xen-common.c
|
|
|
|
index 09fce2dd36..91542fc019 100644
|
|
|
|
--- a/stubs/xen-common.c
|
|
|
|
+++ b/stubs/xen-common.c
|
|
|
|
@@ -12,3 +12,12 @@
|
|
|
|
void xenstore_store_pv_console_info(int i, Chardev *chr)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+void xen_blk_resize_cb(void *dev)
|
|
|
|
+{
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+char *xen_blk_get_attached_dev_id(void *dev)
|
|
|
|
+{
|
|
|
|
+ return g_strdup("");
|
|
|
|
+}
|