From: Alexander Graf Date: Fri, 30 Sep 2011 19:40:36 +0200 Subject: linux-user: add binfmt wrapper for argv[0] handling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When using qemu's linux-user binaries through binfmt, argv[0] gets lost along the execution because qemu only gets passed in the full file name to the executable while argv[0] can be something completely different. This breaks in some subtile situations, such as the grep and make test suites. This patch adds a wrapper binary called qemu-$TARGET-binfmt that can be used with binfmt's P flag which passes the full path _and_ argv[0] to the binfmt handler. The binary would be smart enough to be versatile and only exist in the system once, creating the qemu binary path names from its own argv[0]. However, this seemed like it didn't fit the make system too well, so we're currently creating a new binary for each target archictecture. CC: Reinhard Max Signed-off-by: Alexander Graf [AF: Rebased onto new Makefile infrastructure, twice] [AF: Updated for aarch64 for v2.0.0-rc1] [AF: Rebased onto Makefile changes for v2.1.0-rc0] [AF: Rebased onto script rewrite for v2.7.0-rc2 - to be fixed] Signed-off-by: Andreas Färber --- linux-user/binfmt.c | 42 ++++++++++++++++++++++++++++++++++++++++++ meson.build | 5 +++++ 2 files changed, 47 insertions(+) diff --git a/linux-user/binfmt.c b/linux-user/binfmt.c new file mode 100644 index 0000000000000000000000000000000000000000..cd1f513b334f3b263d9e4b5adb1981e376429fa6 --- /dev/null +++ b/linux-user/binfmt.c @@ -0,0 +1,42 @@ +#include +#include +#include +#include +#include +#include + + +int main(int argc, char **argv, char **envp) +{ + char *binfmt; + char **new_argv; + + /* + * Check if our file name ends with -binfmt + */ + binfmt = argv[0] + strlen(argv[0]) - strlen("-binfmt"); + if (strcmp(binfmt, "-binfmt")) { + fprintf(stderr, "%s: Invalid executable name\n", argv[0]); + exit(1); + } + if (argc < 3) { + fprintf(stderr, "%s: Please use me through binfmt with P flag\n", + argv[0]); + exit(1); + } + + binfmt[0] = '\0'; + /* Now argv[0] is the real qemu binary name */ + + new_argv = (char **)malloc((argc + 2) * sizeof(*new_argv)); + if (argc > 3) { + memcpy(&new_argv[4], &argv[3], (argc - 3) * sizeof(*new_argv)); + } + new_argv[0] = argv[0]; + new_argv[1] = (char *)"-0"; + new_argv[2] = argv[2]; + new_argv[3] = argv[1]; + new_argv[argc + 1] = NULL; + + return execve(new_argv[0], new_argv, envp); +} diff --git a/meson.build b/meson.build index 96de1a6ef948542aa93bd0324200..612da7167f5c4aafcf77a0e1ce55 100644 --- a/meson.build +++ b/meson.build @@ -3043,6 +3043,11 @@ endforeach # Other build targets +if 'CONFIG_LINUX_USER' in config_target + executable('qemu-binfmt', files('linux-user/binfmt.c'), + install: true) +endif + if 'CONFIG_PLUGIN' in config_host install_headers('include/qemu/qemu-plugin.h') endif