From e176ceb6119cacf3d62d04efc8382a05e5d8db48 Mon Sep 17 00:00:00 2001 From: Andreas Schwab Date: Thu, 8 Sep 2016 11:21:05 +0200 Subject: [PATCH] linux-user: properly test for infinite timeout in poll (#8) After "linux-user: use target_ulong" the poll syscall was no longer handling infinite timeout. /home/abuild/rpmbuild/BUILD/qemu-2.7.0-rc5/linux-user/syscall.c:9773:26: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if (arg3 >= 0) { ^~ Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 8b75b1f588..25b0a2ce69 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -10240,7 +10240,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_ulong arg1, { struct timespec ts, *pts; - if (arg3 >= 0) { + if ((abi_long)arg3 >= 0) { /* Convert ms to secs, ns */ ts.tv_sec = arg3 / 1000; ts.tv_nsec = (arg3 % 1000) * 1000000LL;