86ffd40d11
- Switch method of splitting off hw-s390x-virtio-gpu-ccw.so as a module to what was accepted upstream (bsc#1181103) * Patches dropped: hw-s390x-modularize-virtio-gpu-ccw.patch * Patches added: s390x-add-have_virtio_ccw.patch s390x-modularize-virtio-gpu-ccw.patch s390x-move-S390_ADAPTER_SUPPRESSIBLE.patch - Fix OOB access in sdhci interface (CVE-2020-17380, bsc#1175144, CVE-2020-25085, bsc#1176681, CVE-2021-3409, bsc#1182282) hw-sd-sd-Actually-perform-the-erase-oper.patch hw-sd-sd-Fix-build-error-when-DEBUG_SD-i.patch hw-sd-sdhci-Correctly-set-the-controller.patch hw-sd-sdhci-Don-t-transfer-any-data-when.patch hw-sd-sdhci-Don-t-write-to-SDHC_SYSAD-re.patch hw-sd-sdhci-Limit-block-size-only-when-S.patch hw-sd-sdhci-Reset-the-data-pointer-of-s-.patch hw-sd-sd-Move-the-sd_block_-read-write-a.patch hw-sd-sd-Skip-write-protect-groups-check.patch - Fix potential privilege escalation in virtiofsd tool (CVE-2021-20263, bsc#1183373) tools-virtiofsd-Replace-the-word-whiteli.patch viriofsd-Add-support-for-FUSE_HANDLE_KIL.patch virtiofsd-extract-lo_do_open-from-lo_ope.patch virtiofsd-optionally-return-inode-pointe.patch virtiofsd-prevent-opening-of-special-fil.patch virtiofs-drop-remapped-security.capabili.patch virtiofsd-Save-error-code-early-at-the-f.patch - Fix OOB access (stack overflow) in rtl8139 NIC emulation (CVE-2021-3416, bsc#1182968) net-introduce-qemu_receive_packet.patch rtl8139-switch-to-use-qemu_receive_packe.patch - Fix OOB access (stack overflow) in other NIC emulations (CVE-2021-3416) cadence_gem-switch-to-use-qemu_receive_p.patch dp8393x-switch-to-use-qemu_receive_packe.patch e1000-switch-to-use-qemu_receive_packet-.patch lan9118-switch-to-use-qemu_receive_packe.patch msf2-mac-switch-to-use-qemu_receive_pack.patch pcnet-switch-to-use-qemu_receive_packet-.patch sungem-switch-to-use-qemu_receive_packet.patch tx_pkt-switch-to-use-qemu_receive_packet.patch - Fix heap overflow in MSIx emulation (CVE-2020-27821, bsc#1179686) memory-clamp-cached-translation-in-case-.patch - Include upstream patches designated as stable material and reviewed for applicability to include here hw-arm-virt-Disable-pl011-clock-migratio.patch xen-block-Fix-removal-of-backend-instanc.patch - Fix package scripts to not use hard coded paths for temporary working directories and log files (bsc#1182425) OBS-URL: https://build.opensuse.org/request/show/882222 OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=632
50 lines
1.8 KiB
Diff
50 lines
1.8 KiB
Diff
From: Anthony PERARD <anthony.perard@citrix.com>
|
|
Date: Mon, 8 Mar 2021 14:32:32 +0000
|
|
Subject: xen-block: Fix removal of backend instance via xenstore
|
|
|
|
Git-commit: b807ca3fa0ca29ec015adcf4045e716337cd3635
|
|
|
|
Whenever a Xen block device is detach via xenstore, the image
|
|
associated with it remained open by the backend QEMU and an error is
|
|
logged:
|
|
qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use
|
|
|
|
This happened since object_unparent() doesn't immediately frees the
|
|
object and thus keep a reference to the node we are trying to free.
|
|
The reference is hold by the "drive" property and the call
|
|
xen_block_drive_destroy() fails.
|
|
|
|
In order to fix that, we call drain_call_rcu() to run the callback
|
|
setup by bus_remove_child() via object_unparent().
|
|
|
|
Fixes: 2d24a6466154 ("device-core: use RCU for list of children of a bus")
|
|
|
|
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
|
|
Reviewed-by: Paul Durrant <paul@xen.org>
|
|
Message-Id: <20210308143232.83388-1-anthony.perard@citrix.com>
|
|
Signed-off-by: Bruce Rogers <brogers@suse.com>
|
|
---
|
|
hw/block/xen-block.c | 9 +++++++++
|
|
1 file changed, 9 insertions(+)
|
|
|
|
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
|
|
index 20b23c699bc1cb4cd796bf352c45..b1a3fa9b6a91f7748ce54d77cad6 100644
|
|
--- a/hw/block/xen-block.c
|
|
+++ b/hw/block/xen-block.c
|
|
@@ -978,6 +978,15 @@ static void xen_block_device_destroy(XenBackendInstance *backend,
|
|
|
|
object_unparent(OBJECT(xendev));
|
|
|
|
+ /*
|
|
+ * Drain all pending RCU callbacks as object_unparent() frees `xendev'
|
|
+ * in a RCU callback.
|
|
+ * And due to the property "drive" still existing in `xendev', we
|
|
+ * can't destroy the XenBlockDrive associated with `xendev' with
|
|
+ * xen_block_drive_destroy() below.
|
|
+ */
|
|
+ drain_call_rcu();
|
|
+
|
|
if (iothread) {
|
|
xen_block_iothread_destroy(iothread, errp);
|
|
if (*errp) {
|