22d292425f
Update to v2.3.0-rc4 OBS-URL: https://build.opensuse.org/request/show/298607 OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=253
102 lines
3.5 KiB
Diff
102 lines
3.5 KiB
Diff
From a407a470a946fb16deb54e5927841ee12e528ad5 Mon Sep 17 00:00:00 2001
|
|
From: Ulrich Hecht <uli@suse.de>
|
|
Date: Tue, 14 Apr 2009 16:37:42 +0200
|
|
Subject: [PATCH] block/vmdk: Support creation of SCSI VMDK images in qemu-img
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Signed-off-by: Ulrich Hecht <uli@suse.de>
|
|
[AF: Changed BLOCK_FLAG_SCSI from 8 to 16 for v1.2]
|
|
[AF: Rebased onto upstream VMDK SCSI support]
|
|
[AF: Rebased onto skipping of image creation in v1.7]
|
|
[AF: Simplified in preparation for v1.7.1/v2.0]
|
|
[AF: Rebased onto QemuOpts conversion for v2.1]
|
|
Signed-off-by: Andreas Färber <afaerber@suse.de>
|
|
---
|
|
block.c | 3 +++
|
|
block/vmdk.c | 10 +++++++++-
|
|
include/block/block_int.h | 2 ++
|
|
qemu-img.c | 7 +++++++
|
|
4 files changed, 21 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/block.c b/block.c
|
|
index f2f8ae7..0d32442 100644
|
|
--- a/block.c
|
|
+++ b/block.c
|
|
@@ -5813,6 +5813,9 @@ void bdrv_img_create(const char *filename, const char *fmt,
|
|
if (!quiet) {
|
|
printf("Formatting '%s', fmt=%s", filename, fmt);
|
|
qemu_opts_print(opts, " ");
|
|
+ if (qemu_opt_get_bool(opts, BLOCK_OPT_SCSI, false)) {
|
|
+ printf(", SCSI");
|
|
+ }
|
|
puts("");
|
|
}
|
|
|
|
diff --git a/block/vmdk.c b/block/vmdk.c
|
|
index 8410a15..2a34dd0 100644
|
|
--- a/block/vmdk.c
|
|
+++ b/block/vmdk.c
|
|
@@ -1848,9 +1848,12 @@ static int vmdk_create(const char *filename, QemuOpts *opts, Error **errp)
|
|
if (qemu_opt_get_bool_del(opts, BLOCK_OPT_ZEROED_GRAIN, false)) {
|
|
zeroed_grain = true;
|
|
}
|
|
+ if (qemu_opt_get_bool_del(opts, BLOCK_OPT_SCSI, false)) {
|
|
+ flags |= BLOCK_FLAG_SCSI;
|
|
+ }
|
|
|
|
if (!adapter_type) {
|
|
- adapter_type = g_strdup("ide");
|
|
+ adapter_type = g_strdup(flags & BLOCK_FLAG_SCSI ? "lsilogic" : "ide");
|
|
} else if (strcmp(adapter_type, "ide") &&
|
|
strcmp(adapter_type, "buslogic") &&
|
|
strcmp(adapter_type, "lsilogic") &&
|
|
@@ -2265,6 +2268,11 @@ static QemuOptsList vmdk_create_opts = {
|
|
.help = "Enable efficient zero writes "
|
|
"using the zeroed-grain GTE feature"
|
|
},
|
|
+ {
|
|
+ .name = BLOCK_OPT_SCSI,
|
|
+ .type = QEMU_OPT_BOOL,
|
|
+ .help = "SCSI image"
|
|
+ },
|
|
{ /* end of list */ }
|
|
}
|
|
};
|
|
diff --git a/include/block/block_int.h b/include/block/block_int.h
|
|
index dccb092..decca62 100644
|
|
--- a/include/block/block_int.h
|
|
+++ b/include/block/block_int.h
|
|
@@ -41,10 +41,12 @@
|
|
#define BLOCK_FLAG_ENCRYPT 1
|
|
#define BLOCK_FLAG_COMPAT6 4
|
|
#define BLOCK_FLAG_LAZY_REFCOUNTS 8
|
|
+#define BLOCK_FLAG_SCSI 16
|
|
|
|
#define BLOCK_OPT_SIZE "size"
|
|
#define BLOCK_OPT_ENCRYPT "encryption"
|
|
#define BLOCK_OPT_COMPAT6 "compat6"
|
|
+#define BLOCK_OPT_SCSI "scsi"
|
|
#define BLOCK_OPT_BACKING_FILE "backing_file"
|
|
#define BLOCK_OPT_BACKING_FMT "backing_fmt"
|
|
#define BLOCK_OPT_CLUSTER_SIZE "cluster_size"
|
|
diff --git a/qemu-img.c b/qemu-img.c
|
|
index 9dddfbe..cc8e976 100644
|
|
--- a/qemu-img.c
|
|
+++ b/qemu-img.c
|
|
@@ -1602,6 +1602,13 @@ static int img_convert(int argc, char **argv)
|
|
}
|
|
}
|
|
|
|
+ if (qemu_opt_get_bool(opts, BLOCK_OPT_SCSI, false)
|
|
+ && strcmp(drv->format_name, "vmdk")) {
|
|
+ error_report("SCSI devices not supported for this file format");
|
|
+ ret = -1;
|
|
+ goto out;
|
|
+ }
|
|
+
|
|
if (!skip_create) {
|
|
/* Create the new image */
|
|
ret = bdrv_create(drv, out_filename, opts, &local_err);
|