36ac86c950
Update to rc4 of v2.9.0. Also includes a few other fixes, and a number of tweaks to the spec files. I'd be happy to answer any questions about all those spec file changes, I believe they were all in the direction of a more correct and maintainable spec file. Since this is still in rc phase, let's keep it in devel project. Final release should appear in time for Beta2 of SLE12SP3. Delta from previous: Added Alex's patch for keyboard empty event. OBS-URL: https://build.opensuse.org/request/show/487699 OBS-URL: https://build.opensuse.org/package/show/Virtualization/qemu?expand=0&rev=334
56 lines
2.0 KiB
Diff
56 lines
2.0 KiB
Diff
From f39de4c31131d5380aa53bbd7462c1f2c1eb1578 Mon Sep 17 00:00:00 2001
|
|
From: Chunyan Liu <cyliu@suse.com>
|
|
Date: Thu, 3 Mar 2016 16:48:17 +0800
|
|
Subject: [PATCH] Fix tigervnc long press issue
|
|
|
|
Using xen tools 'xl vncviewer' with tigervnc (default on SLE-12),
|
|
found that: the display of the guest is unexpected while keep
|
|
pressing a key. We expect the same character multiple times, but
|
|
it prints only one time. This happens on a PV guest in text mode.
|
|
|
|
After debugging, found that tigervnc sends repeated key down events
|
|
in this case, to differentiate from user pressing the same key many
|
|
times. Vnc server only prints the character when it finally receives
|
|
key up event.
|
|
|
|
To solve this issue, this patch tries to add additional key up event
|
|
before the next repeated key down event (if the key is not a control
|
|
key).
|
|
|
|
[CYL: BSC#882405]
|
|
Signed-off-by: Chunyan Liu <cyliu@suse.com>
|
|
---
|
|
ui/vnc.c | 19 +++++++++++++++++++
|
|
1 file changed, 19 insertions(+)
|
|
|
|
diff --git a/ui/vnc.c b/ui/vnc.c
|
|
index 486d2759e4..51d6f2353f 100644
|
|
--- a/ui/vnc.c
|
|
+++ b/ui/vnc.c
|
|
@@ -1668,6 +1668,25 @@ static void do_key_event(VncState *vs, int down, int keycode, int sym)
|
|
if (down)
|
|
vs->modifiers_state[keycode] ^= 1;
|
|
break;
|
|
+ default:
|
|
+ if (qemu_console_is_graphic(NULL)) {
|
|
+ /* record key 'down' info. Some client like tigervnc
|
|
+ * will send key down repeatedly if user pressing a
|
|
+ * a key for long time. In this case, we should add
|
|
+ * additional key up event before repeated key down,
|
|
+ * so that it can display the key multiple times.
|
|
+ */
|
|
+ if (down) {
|
|
+ if (vs->modifiers_state[keycode]) {
|
|
+ /* add a key up event */
|
|
+ do_key_event(vs, 0, keycode, sym);
|
|
+ }
|
|
+ vs->modifiers_state[keycode] = 1;
|
|
+ } else {
|
|
+ vs->modifiers_state[keycode] = 0;
|
|
+ }
|
|
+ }
|
|
+ break;
|
|
}
|
|
|
|
/* Turn off the lock state sync logic if the client support the led
|