2018-07-11 11:09:56 +02:00
|
|
|
Index: rpmlint-rpmlint-1.10/BinariesCheck.py
|
|
|
|
===================================================================
|
|
|
|
--- rpmlint-rpmlint-1.10.orig/BinariesCheck.py
|
|
|
|
+++ rpmlint-rpmlint-1.10/BinariesCheck.py
|
2019-01-09 19:32:02 +01:00
|
|
|
@@ -549,10 +549,14 @@ class BinariesCheck(AbstractCheck.Abstra
|
2018-07-11 11:09:56 +02:00
|
|
|
if ocaml_mixed_regex.search(bin_info.tail):
|
|
|
|
printWarning(pkg, 'ocaml-mixed-executable', fname)
|
|
|
|
|
|
|
|
- if ((not is_shobj and not is_pie_exec) and
|
|
|
|
- pie_exec_re and pie_exec_re.search(fname)):
|
|
|
|
- printError(pkg, 'non-position-independent-executable',
|
|
|
|
- fname)
|
|
|
|
+ if (not is_shobj and not is_pie_exec):
|
|
|
|
+ if pie_exec_re and pie_exec_re.search(fname):
|
|
|
|
+ printError(
|
|
|
|
+ pkg, 'non-position-independent-executable', fname)
|
|
|
|
+ else:
|
|
|
|
+ printWarning(
|
|
|
|
+ pkg, 'position-independent-executable-suggested',
|
|
|
|
+ fname)
|
|
|
|
|
|
|
|
if bin_info.readelf_error:
|
|
|
|
continue
|
2019-01-09 19:32:02 +01:00
|
|
|
@@ -804,6 +808,10 @@ stripping process.''',
|
2018-07-11 11:09:56 +02:00
|
|
|
'''This executable must be position independent. Check that it is built with
|
|
|
|
-fPIE/-fpie in compiler flags and -pie in linker flags.''',
|
|
|
|
|
|
|
|
+'position-independent-executable-suggested',
|
|
|
|
+'''This executable should be position independent (all binaries should). Check
|
|
|
|
+that it is built with -fPIE/-fpie in compiler flags and -pie in linker flags.''',
|
|
|
|
+
|
|
|
|
'missing-call-to-setgroups-before-setuid',
|
|
|
|
'''This executable is calling setuid and setgid without setgroups or
|
|
|
|
initgroups. There is a high probability this means it didn't relinquish all
|