2008-04-17 04:52:37 +02:00
|
|
|
--- SpecCheck.py
|
|
|
|
+++ SpecCheck.py
|
2009-08-21 18:19:06 +02:00
|
|
|
@@ -53,6 +53,7 @@
|
2008-06-25 19:08:32 +02:00
|
|
|
comment_or_empty_regex = re.compile('^\s*(#|$)')
|
|
|
|
defattr_regex = re.compile('^\s*%defattr\\b')
|
|
|
|
attr_regex = re.compile('^\s*%attr\\b')
|
2008-04-17 04:52:37 +02:00
|
|
|
+suse_version_regex = re.compile('%suse_version\s*[<>=]+\s*(\d+)')
|
2009-08-21 18:19:06 +02:00
|
|
|
section_regexs = dict(
|
|
|
|
([x, re.compile('^%' + x + '(?:\s|$)')]
|
|
|
|
for x in ('build', 'changelog', 'check', 'clean', 'description', 'files',
|
|
|
|
@@ -359,6 +360,12 @@
|
2009-03-13 16:06:45 +01:00
|
|
|
if res:
|
2009-08-21 18:19:06 +02:00
|
|
|
package_noarch[current_package] = True
|
2008-04-17 04:52:37 +02:00
|
|
|
|
2009-03-13 16:06:45 +01:00
|
|
|
+ res = suse_version_regex.search(line)
|
|
|
|
+ if res and int(res.group(1)) > 0 and int(res.group(1)) < 1030:
|
|
|
|
+ printWarning(pkg, "obsolete-suse-version-check", res.group(1))
|
|
|
|
+ elif res and int(res.group(1)) > 1110:
|
|
|
|
+ printError(pkg, "invalid-suse-version-check", res.group(1))
|
2008-04-17 04:52:37 +02:00
|
|
|
+
|
2009-03-13 16:06:45 +01:00
|
|
|
res = prereq_regex.search(line)
|
|
|
|
if res:
|
|
|
|
printError(pkg, 'prereq-use', res.group(2))
|
2009-08-21 18:19:06 +02:00
|
|
|
@@ -645,6 +652,15 @@
|
2008-06-25 19:08:32 +02:00
|
|
|
depending on the system where the package is built. Add default attributes
|
|
|
|
using %defattr before it in the %files section, or use per line %attr's.''',
|
2009-08-21 18:19:06 +02:00
|
|
|
|
2008-04-17 04:52:37 +02:00
|
|
|
+'obsolete-suse-version-check',
|
|
|
|
+'''The specfile contains a comparison of %suse_version against a suse release
|
|
|
|
+that is no longer in maintenance. Consider removing obsolete parts of your
|
|
|
|
+spec file to make it more readable.''',
|
|
|
|
+
|
|
|
|
+'invalid-suse-version-check',
|
|
|
|
+'''The specfile contains a comparison of %suse_version against a suse release
|
2009-08-21 18:19:06 +02:00
|
|
|
+that does not exist. Please double check.''',
|
2008-06-25 19:08:32 +02:00
|
|
|
+
|
2009-08-21 18:19:06 +02:00
|
|
|
'non-standard-group',
|
|
|
|
'''The value of the Group tag in the package is not valid. Valid groups are:
|
|
|
|
"%s".''' % '", "'.join(VALID_GROUPS),
|