SHA256
1
0
forked from pool/rpmlint
rpmlint/suse-no-run-ldconfig.diff

29 lines
1.2 KiB
Diff
Raw Normal View History

--- SpecCheck.py
+++ SpecCheck.py
@@ -359,6 +359,10 @@ class SpecCheck(AbstractCheck.AbstractCheck):
if scriptlet_requires_regex.search(line) and current_section == 'package':
printError(pkg, 'broken-syntax-in-scriptlet-requires', string.strip(line))
+ if current_section in ('post', 'postun'):
+ if line.find('%run_ldconfig') != -1:
+ printWarning(pkg, 'deprecated-use-of-%run_ldconfig')
+
if current_section == 'changelog':
res = macro_regex.search(line)
if res and len(res.group(1)) % 2:
@@ -572,6 +576,14 @@ will break short circuiting.''',
'''Make check or other automated regression test should be run in %check, as
they can be disabled with a rpm macro for short circuiting purposes.''',
+'deprecated-use-of-%run_ldconfig',
+'''According to the new SUSE Packaging Conventions, the use of %run_ldconfig
+is deprecated. use
+
+%post(un) -p /sbin/ldconfig
+
+instead.''',
+
'macro-in-%changelog',
'''Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that