2011-04-21 12:12:02 +02:00
|
|
|
Index: TagsCheck.py
|
|
|
|
===================================================================
|
|
|
|
--- TagsCheck.py.orig
|
2008-06-22 01:52:46 +02:00
|
|
|
+++ TagsCheck.py
|
2011-04-21 12:12:02 +02:00
|
|
|
@@ -815,6 +815,7 @@ class TagsCheck(AbstractCheck.AbstractCh
|
2008-06-22 01:52:46 +02:00
|
|
|
|
2010-10-14 14:32:03 +02:00
|
|
|
obs_names = [x[0] for x in pkg.obsoletes()]
|
|
|
|
prov_names = [x[0].split(':/')[0] for x in pkg.provides()]
|
2009-03-13 16:06:45 +01:00
|
|
|
+ conf_names = map(lambda x: x[0].split(':/')[0], pkg.conflicts())
|
2008-06-22 01:52:46 +02:00
|
|
|
|
2010-10-14 14:32:03 +02:00
|
|
|
for o in (x for x in obs_names if x not in prov_names):
|
|
|
|
printWarning(pkg, 'obsolete-not-provided', o)
|
2011-04-21 12:12:02 +02:00
|
|
|
@@ -826,6 +827,8 @@ class TagsCheck(AbstractCheck.AbstractCh
|
2009-03-13 16:06:45 +01:00
|
|
|
# https://bugzilla.redhat.com/460872
|
2010-10-14 14:32:03 +02:00
|
|
|
useless_provides = []
|
2009-03-13 16:06:45 +01:00
|
|
|
for p in prov_names:
|
|
|
|
+ if p in conf_names:
|
|
|
|
+ printWarning(pkg, 'conflicts-with-provides', p)
|
2010-10-14 14:32:03 +02:00
|
|
|
if prov_names.count(p) != 1 and p not in useless_provides:
|
|
|
|
useless_provides.append(p)
|
|
|
|
for p in useless_provides:
|
2011-04-21 12:12:02 +02:00
|
|
|
@@ -966,6 +969,10 @@ the Release tag.''',
|
2008-06-22 01:52:46 +02:00
|
|
|
'''There is no Name tag in your package. You have to specify a name using the
|
|
|
|
Name tag.''',
|
|
|
|
|
|
|
|
+'conflicts-with-provides',
|
|
|
|
+'''The same symbolic name is provided and conflicted. This package might be
|
|
|
|
+uninstallable, if versioning matches''',
|
|
|
|
+
|
|
|
|
'non-coherent-filename',
|
|
|
|
'''The file which contains the package should be named
|
|
|
|
<NAME>-<VERSION>-<RELEASE>.<ARCH>.rpm.''',
|