forked from pool/rpmlint
35 lines
1.7 KiB
Diff
35 lines
1.7 KiB
Diff
|
Index: rpmlint-rpmlint-1.10/BinariesCheck.py
|
||
|
|
===================================================================
|
||
|
|
--- rpmlint-rpmlint-1.10.orig/BinariesCheck.py
|
||
|
|
+++ rpmlint-rpmlint-1.10/BinariesCheck.py
|
||
|
|
@@ -543,10 +543,14 @@ class BinariesCheck(AbstractCheck.Abstra
|
||
|
|
if ocaml_mixed_regex.search(bin_info.tail):
|
||
|
|
printWarning(pkg, 'ocaml-mixed-executable', fname)
|
||
|
|
|
||
|
|
- if ((not is_shobj and not is_pie_exec) and
|
||
|
|
- pie_exec_re and pie_exec_re.search(fname)):
|
||
|
|
- printError(pkg, 'non-position-independent-executable',
|
||
|
|
- fname)
|
||
|
|
+ if (not is_shobj and not is_pie_exec):
|
||
|
|
+ if pie_exec_re and pie_exec_re.search(fname):
|
||
|
|
+ printError(
|
||
|
|
+ pkg, 'non-position-independent-executable', fname)
|
||
|
|
+ else:
|
||
|
|
+ printWarning(
|
||
|
|
+ pkg, 'position-independent-executable-suggested',
|
||
|
|
+ fname)
|
||
|
|
|
||
|
|
if bin_info.readelf_error:
|
||
|
|
continue
|
||
|
|
@@ -798,6 +802,10 @@ stripping process.''',
|
||
|
|
'''This executable must be position independent. Check that it is built with
|
||
|
|
-fPIE/-fpie in compiler flags and -pie in linker flags.''',
|
||
|
|
|
||
|
|
+'position-independent-executable-suggested',
|
||
|
|
+'''This executable should be position independent (all binaries should). Check
|
||
|
|
+that it is built with -fPIE/-fpie in compiler flags and -pie in linker flags.''',
|
||
|
|
+
|
||
|
|
'missing-call-to-setgroups-before-setuid',
|
||
|
|
'''This executable is calling setuid and setgid without setgroups or
|
||
|
|
initgroups. There is a high probability this means it didn't relinquish all
|