diff --git a/CheckSUIDPermissions.py b/CheckSUIDPermissions.py index 7c1b2aa..16ea8d4 100644 --- a/CheckSUIDPermissions.py +++ b/CheckSUIDPermissions.py @@ -135,8 +135,9 @@ class SUIDCheck(AbstractCheck.AbstractCheck): else: f += '/' - if type == 010: - if not 'shared object' in pkgfile.magic: + if type == 010 and mode&0111: + # pie binaries have 'shared object' here + if 'ELF' in pkgfile.magic and not 'shared object' in pkgfile.magic: printError(pkg, 'non-position-independent-executable', f) m = self.perms[f]['mode'] diff --git a/rpmlint.changes b/rpmlint.changes index 6dd74aa..0801f35 100644 --- a/rpmlint.changes +++ b/rpmlint.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Fri Aug 5 07:50:21 UTC 2011 - lnussel@suse.de + +- only consider executable ELF files for + non-position-independent-executable check + ------------------------------------------------------------------- Mon Aug 1 07:22:41 UTC 2011 - lnussel@suse.de