SHA256
1
0
forked from pool/rpmlint
OBS User unknown 2008-11-04 16:53:47 +00:00 committed by Git OBS Bridge
parent a0cb96c86d
commit b86bedd5a6
3 changed files with 14 additions and 5 deletions

View File

@ -108,7 +108,7 @@ class SUIDCheck(AbstractCheck.AbstractCheck):
o = "invalid" o = "invalid"
if type == 04: if type == 04:
if f in self.perms: if f in self.perms:
printWarning(pkg, 'dir-without-slash', f) printWarning(pkg, 'permissions-dir-without-slash', f)
else: else:
f += '/' f += '/'
@ -131,9 +131,9 @@ class SUIDCheck(AbstractCheck.AbstractCheck):
if mode&06000: if mode&06000:
msg = '%(file)s is packaged with setuid/setgid bits (0%(mode)o)' % { 'file':f, 'mode':mode } msg = '%(file)s is packaged with setuid/setgid bits (0%(mode)o)' % { 'file':f, 'mode':mode }
if type != 04: if type != 04:
printError(pkg, 'permissions-setuid-bit', msg) printError(pkg, 'permissions-file-setuid-bit', msg)
else: else:
printWarning(pkg, 'permissions-setuid-bit', msg) printWarning(pkg, 'permissions-directory-setuid-bit', msg)
if mode&02: if mode&02:
printError(pkg, 'permissions-world-writable', \ printError(pkg, 'permissions-world-writable', \
@ -162,8 +162,10 @@ remove the slash.""",
"""please use the %attr macro to set the correct permissions.""", """please use the %attr macro to set the correct permissions.""",
'permissions-incorrect-owner', 'permissions-incorrect-owner',
"""please use the %attr macro to set the correct ownership.""", """please use the %attr macro to set the correct ownership.""",
'permissions-setuid-bit', 'permissions-file-setuid-bit',
"""Please remove the setuid/setgid bits or contact security@suse.de for review.""", """Please remove the setuid/setgid bits or contact security@suse.de for review.""",
'permissions-directory-setuid-bit',
"""Please contact security@suse.de for review.""",
'permissions-world-writable', 'permissions-world-writable',
"""Please remove the world writable permissions or contact security@suse.de for review.""" """Please remove the world writable permissions or contact security@suse.de for review."""
) )

View File

@ -1,3 +1,8 @@
-------------------------------------------------------------------
Tue Nov 4 14:45:40 CET 2008 - lnussel@suse.de
- generate a different error for directories with setuid/setgid bit
------------------------------------------------------------------- -------------------------------------------------------------------
Tue Oct 28 10:00:09 CET 2008 - lnussel@suse.de Tue Oct 28 10:00:09 CET 2008 - lnussel@suse.de

View File

@ -22,7 +22,7 @@ Name: rpmlint
BuildRequires: rpm-python BuildRequires: rpm-python
Summary: Rpm correctness checker Summary: Rpm correctness checker
Version: 0.83 Version: 0.83
Release: 42 Release: 43
Source0: %{name}-%{version}.tar.bz2 Source0: %{name}-%{version}.tar.bz2
Source1: config Source1: config
Source1001: config.in Source1001: config.in
@ -218,6 +218,8 @@ rm -rf $RPM_BUILD_ROOT
/usr/share/man/man1/rpmlint.1.gz /usr/share/man/man1/rpmlint.1.gz
%changelog %changelog
* Tue Nov 04 2008 lnussel@suse.de
- generate a different error for directories with setuid/setgid bit
* Tue Oct 28 2008 lnussel@suse.de * Tue Oct 28 2008 lnussel@suse.de
- add check for /etc/permissions violations - add check for /etc/permissions violations
* Wed Sep 03 2008 dmueller@suse.de * Wed Sep 03 2008 dmueller@suse.de