From 37d58a8f4b2b3183354949ce39de151b5d449d9b Mon Sep 17 00:00:00 2001 From: Ludwig Nussel Date: Fri, 10 Apr 2015 14:54:18 +0200 Subject: [PATCH] check for self provides --- TagsCheck.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/TagsCheck.py b/TagsCheck.py index 4141bbc..fa6154c 100644 --- a/TagsCheck.py +++ b/TagsCheck.py @@ -846,6 +846,8 @@ class TagsCheck(AbstractCheck.AbstractCheck): for p in pkg.provides(): value = Pkg.formatRequire(*p) self._unexpanded_macros(pkg, 'Provides %s' % (value,), value) + if p[0] == pkg.name and not p[1]: + printError(pkg, 'unversioned-explicit-self-provides', p[0]) for c in pkg.conflicts(): value = Pkg.formatRequire(*c) @@ -1180,6 +1182,10 @@ objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator.''', + +'unversioned-explicit-self-provides', +'''This package provides it's own name explicitely, which might break +upgrade path. self-provides are autogenerated. Remove the provide.''', ) # TagsCheck.py ends here