From 5a0f99a9f522944a0933cd06f9010a96bef9b7b3 Mon Sep 17 00:00:00 2001 From: Dirk Mueller Date: Tue, 10 Oct 2017 11:02:57 +0200 Subject: [PATCH] Avoid false positives on is_elf check "symbolic link to `SELF-WE-PD-XXL.wings'" matched the "ELF" in magic logic. So make it more strict by enforcing that the magic needs to start with "ELF " which seems to match everywhere (PIE executables, normal executables, ELF libs). --- BinariesCheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: rpmlint-rpmlint-1.10/BinariesCheck.py =================================================================== --- rpmlint-rpmlint-1.10.orig/BinariesCheck.py +++ rpmlint-rpmlint-1.10/BinariesCheck.py @@ -372,7 +372,7 @@ class BinariesCheck(AbstractCheck.Abstra (fname.startswith("/usr/lib64") or fname.startswith("/lib64")): file_in_lib64 = True - is_elf = 'ELF' in pkgfile.magic + is_elf = pkgfile.magic.startswith('ELF ') is_ar = 'current ar archive' in pkgfile.magic is_ocaml_native = 'Objective caml native' in pkgfile.magic is_lua_bytecode = 'Lua bytecode' in pkgfile.magic