forked from pool/rpmlint
Dirk Mueller
1d8d6856a8
* Avoid exception on inaccessible scripts * Print out the error content on UnicodeError to make flake8 happy * Fix flake8 warning about missing space around operators * Use compressions when checking for backup files * Account for arch specific code in /usr/share * Check for installed libtool wrapper files * Check for missing optional dependencies * Consider gnome help for doc files * Check for noarch package with files in lib64 * Verify if description is longer than summary * Explicitly tell users how to set URL * Ignore pytest_cache directory * confusing-invalid-spec-name * Ignore orig/rej leftovers after patching * Reenable Travis testing against Fedora Rawhide * Check all sections that should not use %buildroot in them * Put in default buildroot value used by Fedora/openSUSE * Stricter interpreter check * Use compileall to avoid %buildroot to be in pyc * Drop deprecated config file usage, 0.88 is pretty old anyway * Adjust Version to not print outdated Copyright * Rework Travis checks against latest Centos and Fedora releases * Fix exception handling * Fix various flake8-import-order test regressions * Blacklist newer pycodestyle warnings * Fix compatibility with file 5.33+ * Python 3.7.0b5 magic number is 3394 * Update TagsCheck.py * pyc related tests: DRY OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=648
35 lines
1.7 KiB
Diff
35 lines
1.7 KiB
Diff
Index: rpmlint-rpmlint-1.11/BinariesCheck.py
|
|
===================================================================
|
|
--- rpmlint-rpmlint-1.11.orig/BinariesCheck.py
|
|
+++ rpmlint-rpmlint-1.11/BinariesCheck.py
|
|
@@ -558,10 +558,14 @@ class BinariesCheck(AbstractCheck.Abstra
|
|
if ocaml_mixed_regex.search(bin_info.tail):
|
|
printWarning(pkg, 'ocaml-mixed-executable', fname)
|
|
|
|
- if ((not is_shobj and not is_pie_exec) and
|
|
- pie_exec_re and pie_exec_re.search(fname)):
|
|
- printError(pkg, 'non-position-independent-executable',
|
|
- fname)
|
|
+ if (not is_shobj and not is_pie_exec):
|
|
+ if pie_exec_re and pie_exec_re.search(fname):
|
|
+ printError(
|
|
+ pkg, 'non-position-independent-executable', fname)
|
|
+ else:
|
|
+ printWarning(
|
|
+ pkg, 'position-independent-executable-suggested',
|
|
+ fname)
|
|
|
|
if bin_info.readelf_error:
|
|
continue
|
|
@@ -810,6 +814,10 @@ stripping process.''',
|
|
'''This executable must be position independent. Check that it is built with
|
|
-fPIE/-fpie in compiler flags and -pie in linker flags.''',
|
|
|
|
+'position-independent-executable-suggested',
|
|
+'''This executable should be position independent (all binaries should). Check
|
|
+that it is built with -fPIE/-fpie in compiler flags and -pie in linker flags.''',
|
|
+
|
|
'missing-call-to-setgroups-before-setuid',
|
|
'''This executable is calling setuid and setgid without setgroups or
|
|
initgroups. There is a high probability this means it didn't relinquish all
|