forked from pool/rpmlint
Dirk Mueller
1cdbc13b57
* test: Skip fedoradev GPG checks at least for now * test: Refresh fedora* packages on image build * test: Use assertEqual where appropriate, thanks to flake8/hacking * test: Update fedora24 config to fedora26, run it on Travis * Add a new test for tmpfiles.d snippets in the /etc/ tree. * Add new tests for systemd units and udev rules in /etc/ tree * test: Disable hacking for now until it's flake8 3.4+ compatible * test: Set up flake8-bugbear, enable it in fedoradev container * rpmlint: Avoid unused loop control variable * ZipCheck: Add TODO * *: Avoid mutable argument defaults * Be aware of -debugsource packages * rpmdiff: Fix unused variable from previous commit * rpmdiff: Support soft dependencies * BinariesCheck, FilesCheck: Ignore various .build-id dirs * Add python3-devel and rpm-build to fedoradev container to provoke some issues * BinariesCheck: Popen env consistency fix * Pkg.getstatusoutput: Set LC_ALL for all Popens, defaulting to C * rpmlint: Fix checking specfile from stdin * test.sh: Extract rpmlint command to run_rpmlint * Revert "Remove unused spec_lines check_spec argument" * BinariesCheck: Trivial cleanups * travis: Run make install too * FilesCheck: Allow multiple bytecode magic values per Python version * tests: Make output test tools easier to reuse * FilesCheck: hg.python.org -> github.com/python * Pkg: Return vendor and distribution as unicode strings * FilesCheck: Add Python 3.7 bytecode magic value * Pkg.b2s: Add some more test cases OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=482
59 lines
2.2 KiB
Diff
59 lines
2.2 KiB
Diff
From: Some One <nobody@opensuse.org>
|
|
Date: Thu, 9 Apr 2015 14:55:39 +0200
|
|
Subject: [PATCH] noarch-lib64.diff
|
|
|
|
===================================================================
|
|
---
|
|
BinariesCheck.py | 15 ++++++++++++++-
|
|
1 file changed, 14 insertions(+), 1 deletion(-)
|
|
|
|
Index: rpmlint-rpmlint-1.10/BinariesCheck.py
|
|
===================================================================
|
|
--- rpmlint-rpmlint-1.10.orig/BinariesCheck.py
|
|
+++ rpmlint-rpmlint-1.10/BinariesCheck.py
|
|
@@ -348,6 +348,7 @@ class BinariesCheck(AbstractCheck.Abstra
|
|
binary = False
|
|
binary_in_usr_lib = False
|
|
has_usr_lib_file = False
|
|
+ file_in_lib64 = False
|
|
|
|
multi_pkg = False
|
|
srpm = pkg[rpm.RPMTAG_SOURCERPM]
|
|
@@ -366,6 +367,10 @@ class BinariesCheck(AbstractCheck.Abstra
|
|
# only-non-binary-in-usr-lib false positives
|
|
binary_in_usr_lib = True
|
|
|
|
+ if stat.S_ISREG(pkgfile.mode) and \
|
|
+ (fname.startswith("/usr/lib64") or fname.startswith("/lib64")):
|
|
+ file_in_lib64 = True
|
|
+
|
|
is_elf = 'ELF' in pkgfile.magic
|
|
is_ar = 'current ar archive' in pkgfile.magic
|
|
is_ocaml_native = 'Objective caml native' in pkgfile.magic
|
|
@@ -599,9 +604,12 @@ class BinariesCheck(AbstractCheck.Abstra
|
|
if version and version != -1 and version not in pkg.name:
|
|
printError(pkg, 'incoherent-version-in-name', version)
|
|
|
|
- if not binary and not multi_pkg and pkg.arch != 'noarch':
|
|
+ if not binary and not multi_pkg and not file_in_lib64 and pkg.arch != 'noarch':
|
|
printError(pkg, 'no-binary')
|
|
|
|
+ if pkg.arch == 'noarch' and file_in_lib64:
|
|
+ printError(pkg, 'noarch-with-lib64')
|
|
+
|
|
if has_usr_lib_file and not binary_in_usr_lib:
|
|
printWarning(pkg, 'only-non-binary-in-usr-lib')
|
|
|
|
@@ -626,6 +634,11 @@ FHS and the FSSTND forbid this.''',
|
|
# 'non-sparc32-binary',
|
|
# '',
|
|
|
|
+'noarch-with-lib64',
|
|
+'''This package is marked as noarch but installs files into lib64.
|
|
+Not all architectures have this in path, so the package can't be
|
|
+noarch.''',
|
|
+
|
|
'invalid-soname',
|
|
'''The soname of the library is neither of the form lib<libname>.so.<major> or
|
|
lib<libname>-<major>.so.''',
|