forked from pool/rpmlint
Ludwig Nussel
5ad6c8a066
+ add ghost file checks + print names of failed tests - fix update_git.sh - make sure tmpfiles are listed in %files (add-check-for-tmpfiles-created-at-r.diff) - don't complain about missingok ghost files (fix-ghost-file-handling.diff) - remove obsolete check for %defattr in spec files (remove-files-attr-not-set-check.diff) OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=328
43 lines
2.0 KiB
Diff
43 lines
2.0 KiB
Diff
From: Some One <nobody@opensuse.org>
|
|
Date: Thu, 9 Apr 2015 14:55:38 +0200
|
|
Subject: [PATCH] docdata-examples.diff
|
|
|
|
===================================================================
|
|
---
|
|
FilesCheck.py | 8 ++++++--
|
|
1 file changed, 6 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/FilesCheck.py b/FilesCheck.py
|
|
index c485125..7504167 100644
|
|
--- a/FilesCheck.py
|
|
+++ b/FilesCheck.py
|
|
@@ -609,6 +609,7 @@ bin_regex = re.compile('^/(?:usr/(?:s?bin|games)|s?bin)/(.*)')
|
|
includefile_regex = re.compile('\.(c|h)(pp|xx)?$', re.IGNORECASE)
|
|
develfile_regex = re.compile('\.(a|cmxa?|mli?)$')
|
|
buildconfigfile_regex = re.compile('(\.pc|/bin/.+-config)$')
|
|
+docdir_examples_regex = re.compile('^/usr/(?:share/doc/packages|lib(?:64))/[^/]+/(?:example|demo|script|contrib)')
|
|
# room for improvement with catching more -R, but also for false positives...
|
|
buildconfig_rpath_regex = re.compile('(?:-rpath|Wl,-R)\\b')
|
|
sofile_regex = re.compile('/lib(64)?/(.+/)?lib[^/]+\.so$')
|
|
@@ -1181,7 +1182,7 @@ class FilesCheck(AbstractCheck.AbstractCheck):
|
|
includefile_regex.search(f) or \
|
|
develfile_regex.search(f) or \
|
|
logrotate_regex.search(f)
|
|
- if nonexec_file:
|
|
+ if nonexec_file and not docdir_examples_regex.search(f):
|
|
printWarning(pkg, 'spurious-executable-perm', f)
|
|
elif f.startswith('/etc/') and f not in config_files and \
|
|
f not in ghost_files:
|
|
@@ -1534,7 +1535,10 @@ included in your package.''',
|
|
'spurious-executable-perm',
|
|
'''The file is installed with executable permissions, but was identified as one
|
|
that probably should not be executable. Verify if the executable bits are
|
|
-desired, and remove if not.''',
|
|
+desired, and remove if not.
|
|
+NOTE: example scripts should be packaged under %docdir/examples, which will avoid
|
|
+this warning.
|
|
+''',
|
|
|
|
'world-writable',
|
|
'''A file or directory in the package is installed with world writable
|