forked from pool/rpmlint
Dirk Mueller
1d8d6856a8
* Avoid exception on inaccessible scripts * Print out the error content on UnicodeError to make flake8 happy * Fix flake8 warning about missing space around operators * Use compressions when checking for backup files * Account for arch specific code in /usr/share * Check for installed libtool wrapper files * Check for missing optional dependencies * Consider gnome help for doc files * Check for noarch package with files in lib64 * Verify if description is longer than summary * Explicitly tell users how to set URL * Ignore pytest_cache directory * confusing-invalid-spec-name * Ignore orig/rej leftovers after patching * Reenable Travis testing against Fedora Rawhide * Check all sections that should not use %buildroot in them * Put in default buildroot value used by Fedora/openSUSE * Stricter interpreter check * Use compileall to avoid %buildroot to be in pyc * Drop deprecated config file usage, 0.88 is pretty old anyway * Adjust Version to not print outdated Copyright * Rework Travis checks against latest Centos and Fedora releases * Fix exception handling * Fix various flake8-import-order test regressions * Blacklist newer pycodestyle warnings * Fix compatibility with file 5.33+ * Python 3.7.0b5 magic number is 3394 * Update TagsCheck.py * pyc related tests: DRY OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=648
43 lines
2.0 KiB
Diff
43 lines
2.0 KiB
Diff
From: Some One <nobody@opensuse.org>
|
|
Date: Thu, 9 Apr 2015 14:55:38 +0200
|
|
Subject: [PATCH] docdata-examples.diff
|
|
|
|
===================================================================
|
|
---
|
|
FilesCheck.py | 8 ++++++--
|
|
1 file changed, 6 insertions(+), 2 deletions(-)
|
|
|
|
Index: rpmlint-rpmlint-1.11/FilesCheck.py
|
|
===================================================================
|
|
--- rpmlint-rpmlint-1.11.orig/FilesCheck.py
|
|
+++ rpmlint-rpmlint-1.11/FilesCheck.py
|
|
@@ -190,6 +190,7 @@ bin_regex = re.compile(r'^/(?:usr/(?:s?b
|
|
includefile_regex = re.compile(r'\.(c|h)(pp|xx)?$', re.IGNORECASE)
|
|
develfile_regex = re.compile(r'\.(a|cmxa?|mli?|gir)$')
|
|
buildconfigfile_regex = re.compile(r'(\.pc|/bin/.+-config)$')
|
|
+docdir_examples_regex = re.compile('^/usr/(?:share/doc/packages|lib(?:64))/[^/]+/(?:example|demo|script|contrib)')
|
|
# room for improvement with catching more -R, but also for false positives...
|
|
buildconfig_rpath_regex = re.compile(r'(?:-rpath|Wl,-R)\b')
|
|
sofile_regex = re.compile(r'/lib(64)?/(.+/)?lib[^/]+\.so$')
|
|
@@ -820,7 +821,7 @@ class FilesCheck(AbstractCheck.AbstractC
|
|
includefile_regex.search(f) or \
|
|
develfile_regex.search(f) or \
|
|
logrotate_regex.search(f)
|
|
- if nonexec_file:
|
|
+ if nonexec_file and not docdir_examples_regex.search(f):
|
|
printWarning(pkg, 'spurious-executable-perm', f)
|
|
elif f.startswith('/etc/') and f not in config_files and \
|
|
f not in ghost_files:
|
|
@@ -1196,7 +1197,10 @@ included in your package.''',
|
|
'spurious-executable-perm',
|
|
'''The file is installed with executable permissions, but was identified as one
|
|
that probably should not be executable. Verify if the executable bits are
|
|
-desired, and remove if not.''',
|
|
+desired, and remove if not.
|
|
+NOTE: example scripts should be packaged under %docdir/examples, which will avoid
|
|
+this warning.
|
|
+''',
|
|
|
|
'world-writable',
|
|
'''A file or directory in the package is installed with world writable
|