forked from pool/rpmlint
Ludwig Nussel
5ad6c8a066
+ add ghost file checks + print names of failed tests - fix update_git.sh - make sure tmpfiles are listed in %files (add-check-for-tmpfiles-created-at-r.diff) - don't complain about missingok ghost files (fix-ghost-file-handling.diff) - remove obsolete check for %defattr in spec files (remove-files-attr-not-set-check.diff) OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=328
50 lines
2.0 KiB
Diff
50 lines
2.0 KiB
Diff
From: Some One <nobody@opensuse.org>
|
|
Date: Thu, 9 Apr 2015 14:55:39 +0200
|
|
Subject: [PATCH] libtool-wrapper-check.diff
|
|
|
|
===================================================================
|
|
---
|
|
BinariesCheck.py | 20 ++++++++++++++++++++
|
|
1 file changed, 20 insertions(+)
|
|
|
|
diff --git a/BinariesCheck.py b/BinariesCheck.py
|
|
index c1c566d..b92c01e 100644
|
|
--- a/BinariesCheck.py
|
|
+++ b/BinariesCheck.py
|
|
@@ -316,8 +316,19 @@ class BinariesCheck(AbstractCheck.AbstractCheck):
|
|
is_ar = 'current ar archive' in pkgfile.magic
|
|
is_ocaml_native = 'Objective caml native' in pkgfile.magic
|
|
is_lua_bytecode = 'Lua bytecode' in pkgfile.magic
|
|
+ is_shell = "shell script" in pkgfile.magic
|
|
is_binary = is_elf or is_ar or is_ocaml_native or is_lua_bytecode
|
|
|
|
+ if is_shell:
|
|
+ count= 0
|
|
+ for l in file(pkgfile.path, "r"):
|
|
+ count = count + 1
|
|
+ if (l.find("This wrapper script should never be moved out of the build directory") != -1):
|
|
+ printError(pkg, 'libtool-wrapper-in-package', fname)
|
|
+ break
|
|
+ if (count > 20):
|
|
+ break;
|
|
+
|
|
if not is_binary:
|
|
if reference_regex.search(fname):
|
|
lines = pkg.grep(invalid_dir_ref_regex, fname)
|
|
@@ -579,6 +590,15 @@ recompiled separately from the static libraries with the -fPIC option.
|
|
Another common mistake that causes this problem is linking with
|
|
``gcc -Wl,-shared'' instead of ``gcc -shared''.''',
|
|
|
|
+'libtool-wrapper-in-package',
|
|
+'''Your package contains a libtool wrapper shell script. This
|
|
+will not work. Instead of install'ing the libtool wrapper file,
|
|
+run·
|
|
+
|
|
+libtool --mode=install install -m perm <file> <dest>
|
|
+
|
|
+to install the relinked file.''',
|
|
+
|
|
'binary-or-shlib-defines-rpath',
|
|
'''The binary or shared library defines `RPATH'. Usually this is a
|
|
bad thing because it hardcodes the path to search libraries and so
|