forked from pool/rpmlint
33 lines
1.3 KiB
Diff
33 lines
1.3 KiB
Diff
From: Ludwig Nussel <ludwig.nussel@suse.de>
|
|
Date: Fri, 10 Apr 2015 14:54:18 +0200
|
|
Subject: [PATCH] check for self provides
|
|
|
|
---
|
|
TagsCheck.py | 6 ++++++
|
|
1 file changed, 6 insertions(+)
|
|
|
|
Index: rpmlint-rpmlint-1.10/TagsCheck.py
|
|
===================================================================
|
|
--- rpmlint-rpmlint-1.10.orig/TagsCheck.py
|
|
+++ rpmlint-rpmlint-1.10/TagsCheck.py
|
|
@@ -891,6 +891,8 @@ class TagsCheck(AbstractCheck.AbstractCh
|
|
for p in pkg.provides():
|
|
value = Pkg.formatRequire(*p)
|
|
self._unexpanded_macros(pkg, 'Provides %s' % (value,), value)
|
|
+ if p[0] == pkg.name and not p[1]:
|
|
+ printError(pkg, 'unversioned-explicit-self-provides', p[0])
|
|
|
|
for c in pkg.conflicts():
|
|
value = Pkg.formatRequire(*c)
|
|
@@ -1234,6 +1236,10 @@ objects should thus not be depended on a
|
|
in the containing package. Get rid of the provides if appropriate, for example
|
|
by filtering it out during build. Note that in some cases this may require
|
|
disabling rpmbuild's internal dependency generator.''',
|
|
+
|
|
+'unversioned-explicit-self-provides',
|
|
+'''This package provides it's own name explicitely, which might break
|
|
+upgrade path. self-provides are autogenerated. Remove the provide.''',
|
|
)
|
|
|
|
for i in ("obsoletes", "conflicts", "provides", "recommends", "suggests",
|