forked from pool/rpmlint
69 lines
2.7 KiB
Diff
69 lines
2.7 KiB
Diff
--- BinariesCheck.py
|
|
+++ BinariesCheck.py
|
|
@@ -36,6 +36,8 @@
|
|
debug_file_regex=re.compile('\.debug$')
|
|
exit_call_regex = re.compile('\s+FUNC\s+.*?\s+(_?exit(?:@\S+)?)(?:\s|$)')
|
|
fork_call_regex = re.compile('\s+FUNC\s+.*?\s+(fork(?:@\S+)?)(?:\s|$)')
|
|
+ debuginfo_regex=re.compile('^\s+\[\s*\d+\]\s+\.debug_.*\s+')
|
|
+ symtab_regex=re.compile('^\s+\[\s*\d+\]\s+\.symtab\s+')
|
|
|
|
def __init__(self, pkg, path, file, is_ar, is_shlib):
|
|
self.readelf_error = 0
|
|
@@ -50,6 +52,8 @@
|
|
self.exec_stack = 0
|
|
self.exit_calls = []
|
|
fork_called = 0
|
|
+ self.debuginfo = 0
|
|
+ self.symtab=0
|
|
self.tail = ''
|
|
|
|
is_debug=BinaryInfo.debug_file_regex.search(path)
|
|
@@ -102,6 +106,14 @@
|
|
fork_called = 1
|
|
continue
|
|
|
|
+ if BinaryInfo.debuginfo_regex.search(l):
|
|
+ self.debuginfo=1
|
|
+ continue
|
|
+
|
|
+ if BinaryInfo.symtab_regex.search(l):
|
|
+ self.symtab=1
|
|
+ continue
|
|
+
|
|
if self.non_pic:
|
|
self.non_pic=BinaryInfo.non_pic_regex.search(res[1])
|
|
|
|
@@ -249,6 +261,17 @@
|
|
# inspect binary file
|
|
bin_info=BinaryInfo(pkg, pkg.dirName()+i[0], i[0], is_ar, is_shlib)
|
|
|
|
+ # stripped static library
|
|
+ if is_ar:
|
|
+ if bin_info.readelf_error:
|
|
+ pass
|
|
+ elif not bin_info.symtab:
|
|
+ printError(pkg, 'static-library-without-symtab', i[0])
|
|
+ elif not bin_info.debuginfo and \
|
|
+ (os.environ.get('BUILD_IS_RUNNING', None) == None or \
|
|
+ os.environ.get('BUILD_DEBUG_FLAGS','').find('-g') != -1):
|
|
+ printWarning(pkg, 'static-library-without-debuginfo', i[0])
|
|
+
|
|
# so name in library
|
|
if is_shlib:
|
|
has_lib.append(i[0])
|
|
@@ -475,6 +498,14 @@
|
|
'ldd-failed',
|
|
'''Executing ldd on this file failed, all checks could not be run.''',
|
|
|
|
+'static-library-without-symtab',
|
|
+'''The static library doesn't contain any symbols and therefore can't be linked
|
|
+against. This may indicated that it was strip.''',
|
|
+
|
|
+'static-library-without-debuginfo',
|
|
+'''The static library doesn't contain any debuginfo. Binaries linking against
|
|
+this static library can't be properly debugged.''',
|
|
+
|
|
'executable-stack',
|
|
'''The binary declares the stack as executable. Executable stack is usually an
|
|
error as it is only needed if the code contains GCC trampolines or similar
|