forked from pool/rpmlint
Ludwig Nussel
912bea2445
- rpmlint 1.8 update * python 3 fixes * Add support for file triggers * Mechanism to black list certain C calls * new error: non-devel-file-in-devel-package * appdata check configurable * project moved to github * Patches dropped: avoid-mismatched-libregex.diff filename-non-utf8-exception.diff fix-ghost-file-handling.diff save-content-to-an-array.diff fix-TmpFilesCheck-pattern-match.diff move-ghost-file-check-to-TmpFilesCh.diff OBS-URL: https://build.opensuse.org/request/show/346358 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=353
33 lines
1.3 KiB
Diff
33 lines
1.3 KiB
Diff
From: Ludwig Nussel <ludwig.nussel@suse.de>
|
|
Date: Fri, 10 Apr 2015 14:54:18 +0200
|
|
Subject: [PATCH] check for self provides
|
|
|
|
---
|
|
TagsCheck.py | 6 ++++++
|
|
1 file changed, 6 insertions(+)
|
|
|
|
diff --git a/TagsCheck.py b/TagsCheck.py
|
|
index 8071f1d..39b7544 100644
|
|
--- a/TagsCheck.py
|
|
+++ b/TagsCheck.py
|
|
@@ -847,6 +847,8 @@ class TagsCheck(AbstractCheck.AbstractCheck):
|
|
for p in pkg.provides():
|
|
value = Pkg.formatRequire(*p)
|
|
self._unexpanded_macros(pkg, 'Provides %s' % (value,), value)
|
|
+ if p[0] == pkg.name and not p[1]:
|
|
+ printError(pkg, 'unversioned-explicit-self-provides', p[0])
|
|
|
|
for c in pkg.conflicts():
|
|
value = Pkg.formatRequire(*c)
|
|
@@ -1175,6 +1177,10 @@ objects should thus not be depended on and they should not result in provides
|
|
in the containing package. Get rid of the provides if appropriate, for example
|
|
by filtering it out during build. Note that in some cases this may require
|
|
disabling rpmbuild's internal dependency generator.''',
|
|
+
|
|
+'unversioned-explicit-self-provides',
|
|
+'''This package provides it's own name explicitely, which might break
|
|
+upgrade path. self-provides are autogenerated. Remove the provide.''',
|
|
)
|
|
|
|
for i in "obsoletes", "conflicts", "provides", "recommends", "suggests", \
|