SHA256
1
0
forked from pool/rpmlint
rpmlint/rpmlint-all-pie.patch
Dirk Mueller ad07ffcc10 Accepting request 507659 from home:msmeissn:branches:devel:openSUSE:Factory:rpmlint
- rpmlint-pie-leap42.patch, rpmlint-pie-factory.patch:
  adjust testsuite to match new PIE warning, for both
  Leap 42.3 and Factory.

- rpmlint-all-pie.patch: for non-PIE built binaries emit a warning
  to suggest build them as PIE.

OBS-URL: https://build.opensuse.org/request/show/507659
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=464
2017-07-04 12:30:44 +00:00

26 lines
1.2 KiB
Diff

Index: rpmlint-rpmlint-1.8/BinariesCheck.py
===================================================================
--- rpmlint-rpmlint-1.8.orig/BinariesCheck.py
+++ rpmlint-rpmlint-1.8/BinariesCheck.py
@@ -560,6 +560,9 @@ class BinariesCheck(AbstractCheck.Abstra
if not is_shobj and pie_exec_re and pie_exec_re.search(fname):
printError(pkg, 'non-position-independent-executable',
fname)
+ if not is_shobj:
+ printError(pkg, 'position-independent-executable-suggested',
+ fname)
if bin_info.readelf_error:
continue
@@ -809,6 +812,10 @@ stripping process.''',
'''This executable must be position independent. Check that it is built with
-fPIE/-fpie in compiler flags and -pie in linker flags.''',
+'position-independent-executable-suggested',
+'''This executable should be position independent (all binaries should). Check
+that it is built with -fPIE/-fpie in compiler flags and -pie in linker flags.''',
+
'missing-call-to-setgroups-before-setuid',
'''This executable is calling setuid and setgid without setgroups or
initgroups. There is a high probability this means it didn't relinquish all