forked from pool/rpmlint
Dirk Mueller
3073721c60
* rpmdiff: Teach rpmdiff about pretrans and posttrans * SpecCheck.py: merge patch from #97, using BuildArch with something else than Noarch is likely a error and causing issues. * FilesCheck.py: Add Python 3.3 magic number * FilesCheck.py, InitScriptCheck.py, MenuCheck.py, Pkg.py, PostCheck.py: Prepare for rpm-python possibly returning script progs as arrays. OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=133
34 lines
1.7 KiB
Diff
34 lines
1.7 KiB
Diff
Index: FilesCheck.py
|
|
===================================================================
|
|
--- FilesCheck.py.orig
|
|
+++ FilesCheck.py
|
|
@@ -653,6 +653,7 @@ bin_regex = re.compile('^/(?:usr/(?:s?bi
|
|
includefile_regex = re.compile('\.(c|h)(pp|xx)?$', re.IGNORECASE)
|
|
develfile_regex = re.compile('\.(a|cmxa?|mli?)$')
|
|
buildconfigfile_regex = re.compile('(\.pc|/bin/.+-config)$')
|
|
+docdir_examples_regex = re.compile('^/usr/(?:share/doc/packages|lib(?:64))/[^/]+/(?:example|demo|script|contrib)')
|
|
# room for improvement with catching more -R, but also for false positives...
|
|
buildconfig_rpath_regex = re.compile('(?:-rpath|Wl,-R)\\b')
|
|
sofile_regex = re.compile('/lib(64)?/(.+/)?lib[^/]+\.so$')
|
|
@@ -1204,7 +1205,7 @@ class FilesCheck(AbstractCheck.AbstractC
|
|
includefile_regex.search(f) or \
|
|
develfile_regex.search(f) or \
|
|
logrotate_regex.search(f)
|
|
- if nonexec_file:
|
|
+ if nonexec_file and not docdir_examples_regex.search(f):
|
|
printWarning(pkg, 'spurious-executable-perm', f)
|
|
elif f.startswith('/etc/') and f not in config_files and \
|
|
f not in ghost_files:
|
|
@@ -1576,7 +1577,10 @@ included in your package.''',
|
|
'spurious-executable-perm',
|
|
'''The file is installed with executable permissions, but was identified as one
|
|
that probably should not be executable. Verify if the executable bits are
|
|
-desired, and remove if not.''',
|
|
+desired, and remove if not.
|
|
+NOTE: example scripts should be packaged under %docdir/examples, which will avoid
|
|
+this warning.
|
|
+''',
|
|
|
|
'world-writable',
|
|
'''A file or directory in the package is installed with world writable
|