SHA256
1
0
forked from pool/rpmlint
rpmlint/suse-hide-unstripped-outside-build.diff
OBS User autobuild 88b0c395f0 Accepting request 42327 from Base:System
Copy from Base:System/rpmlint based on submit request 42327 from user lnussel

OBS-URL: https://build.opensuse.org/request/show/42327
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/rpmlint?expand=0&rev=64
2010-07-02 14:09:25 +00:00

37 lines
1.4 KiB
Diff

Index: BinariesCheck.py
===================================================================
--- BinariesCheck.py.orig
+++ BinariesCheck.py
@@ -10,6 +10,7 @@
import re
import stat
+import os
import rpm
@@ -271,7 +272,9 @@ class BinariesCheck(AbstractCheck.Abstra
# stripped ?
if not is_ocaml_native and not unstrippable.search(fname):
- if 'not stripped' in pkgfile.magic:
+ if 'not stripped' in pkgfile.magic and \
+ (os.environ.get('BUILD_DIR', None) == None or
+ os.environ.get('BUILD_DEBUG', None) != None):
printWarning(
pkg, 'unstripped-binary-or-object', fname)
@@ -585,6 +588,12 @@ form, make sure that rpmbuild does not s
that use prelink, make sure that prelink does not strip it either, usually by
placing a blacklist file in /etc/prelink.conf.d. For more information, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256900#49''',
+
+'unstripped-binary-or-object',
+'''stripping debug info from binaries happens automatically according to global
+project settings. So there's normally no need to manually strip binaries.
+Left over unstripped binaries could therefore indicate a bug in the automatic
+stripping process.''',
)
# BinariesCheck.py ends here