From 90d7ff58e66ee6e3b2306f05a4f9de9e9fd038bdbd5af0bc4b94f92ee01ea9e0 Mon Sep 17 00:00:00 2001 From: Danilo Spinella Date: Wed, 13 Apr 2022 13:42:45 +0000 Subject: [PATCH] Accepting request 969881 from devel:languages:python - Add patch to fix segfault (seen in %check on aarch64): * e59f703bbcc0af949ee365206426b6394c340c6f.patch OBS-URL: https://build.opensuse.org/request/show/969881 OBS-URL: https://build.opensuse.org/package/show/server:database/rrdtool?expand=0&rev=2 --- ...703bbcc0af949ee365206426b6394c340c6f.patch | 53 +++++++++++++++++++ rrdtool.changes | 6 +++ rrdtool.spec | 3 ++ 3 files changed, 62 insertions(+) create mode 100644 e59f703bbcc0af949ee365206426b6394c340c6f.patch diff --git a/e59f703bbcc0af949ee365206426b6394c340c6f.patch b/e59f703bbcc0af949ee365206426b6394c340c6f.patch new file mode 100644 index 0000000..534716e --- /dev/null +++ b/e59f703bbcc0af949ee365206426b6394c340c6f.patch @@ -0,0 +1,53 @@ +From e59f703bbcc0af949ee365206426b6394c340c6f Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Wolfgang=20St=C3=B6ggl?= +Date: Wed, 23 Mar 2022 17:58:45 +0100 +Subject: [PATCH] Fix BUILD_DATE in rrdtool help output + +- This is a followup to #1102 +- Fixes segfault when running "rrdtool --help" +- Change DATE_FMT to the same date format as the __DATE__ macro [1]: + mmm dd yyyy + +[1] https://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html +--- + configure.ac | 2 +- + src/rrd_tool.c | 8 ++++++++ + 2 files changed, 9 insertions(+), 1 deletion(-) + +diff --git a/configure.ac b/configure.ac +index 4d234585..5169b0d4 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -695,7 +695,7 @@ AC_MSG_RESULT(${COMP_PERL:-No Perl Modules will be built}) + + # Use reproducible build date and time + if test "$SOURCE_DATE_EPOCH"; then +- DATE_FMT="%d %b %Y %H:%M:%S" ++ DATE_FMT="%b %d %Y %H:%M:%S" + BUILD_DATE=$(LC_ALL=C date -u -d "@$SOURCE_DATE_EPOCH" "+$DATE_FMT") + AC_DEFINE_UNQUOTED([BUILD_DATE], ["$BUILD_DATE"], [Use reproducible build date]) + fi +diff --git a/src/rrd_tool.c b/src/rrd_tool.c +index 930d0827..cc6119d9 100644 +--- a/src/rrd_tool.c ++++ b/src/rrd_tool.c +@@ -45,11 +45,19 @@ static void PrintUsage( + char *cmd) + { + ++#ifdef BUILD_DATE ++ const char *help_main = ++ N_("RRDtool %s" ++ " Copyright by Tobias Oetiker \n" ++ " Compiled %s\n\n" ++ "Usage: rrdtool [options] command command_options\n"); ++#else + const char *help_main = + N_("RRDtool %s" + " Copyright by Tobias Oetiker \n" + " Compiled %s %s\n\n" + "Usage: rrdtool [options] command command_options\n"); ++#endif + + const char *help_list = + N_ diff --git a/rrdtool.changes b/rrdtool.changes index 9b55f4d..df5b32b 100644 --- a/rrdtool.changes +++ b/rrdtool.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Wed Apr 13 08:27:59 UTC 2022 - Guillaume GARDET + +- Add patch to fix segfault (seen in %check on aarch64): + * e59f703bbcc0af949ee365206426b6394c340c6f.patch + ------------------------------------------------------------------- Tue Mar 29 13:41:16 UTC 2022 - Danilo Spinella diff --git a/rrdtool.spec b/rrdtool.spec index 1f7ff27..53fce5b 100644 --- a/rrdtool.spec +++ b/rrdtool.spec @@ -43,6 +43,8 @@ Source2: sysconfig.rrdcached Source4: rrdcached-systemd-pre Source5: rrdcached.service Source99: %{name}.changes +# PATCH-FIX-UPSTREAM -- Fix BUILD_DATE in rrdtool help output (fix segfault) +Patch1: https://github.com/oetiker/rrdtool-1.x/commit/e59f703bbcc0af949ee365206426b6394c340c6f.patch # PATCH-FIX-UPSTREAM -- Prevent possible segfault Patch3: rrdtool-tclsegfault.patch # PATCH-FIX-UPSTREAM -- bnc#793636 @@ -212,6 +214,7 @@ daemon was written to alleviate these problems. %prep %setup -q +%patch1 -p1 %patch3 %patch12 -p1 %patch14 -p1