1592ccc37e
- fix argument handling of pkg.download
Add: 0022-fix-argument-handling-for-pkg.download.patch
- unify behavior of zypper refresh in salt
Add: 0018-unify-behavior-of-refresh.patch
0019-add-refresh-option-to-more-functions.patch
0020-simplify-checking-the-refresh-paramater.patch
0021-do-not-change-kwargs-in-refresh-while-checking-a-val.patch
- Fix crash with scheduler and runners
Add: 0017-Fix-crash-with-scheduler-and-runners-31106.patch
- Call zypper always with --non-interactive
Add:
* 0015-call-zypper-with-option-non-interactive-everywhere.patch
* 0016-write-a-zypper-command-builder-function.patch
- require rpm-python on SUSE for zypper support
- fix state return code
Add: 0009-The-functions-in-the-state-module-that-return-a-retc.patch
- add handling of OEM products to pkg.list_products
Add: 0010-add-handling-for-OEM-products.patch
- improve doc for list_pkgs
Add: 0011-improve-doc-for-list_pkgs.patch
- implement pkg.version_cmp in zypper.py
Add:
* 0012-implement-version_cmp-for-zypper.patch
* 0013-pylint-changes.patch
* 0014-Check-if-rpm-python-can-be-imported.patch
- Update to 2015.8.7
this is a small update to fix some regressions
see https://docs.saltstack.com/en/latest/topics/releases/2015.8.7.html
- Booleans should not be strings from XML, add Unix ticks time and
format result in a list of maps.
Add:
* 0008-Fix-types-in-the-output-data-and-return-just-a-list-.patch
- Stop salt-api daemon faster (bsc#963322)
Add:
* 0007-Force-kill-websocket-s-child-processes-faster-than-d.patch
- Do not crash on salt-key reject/delete consecutive calls.
Add:
* 0006-add_key-reject_key-do-not-crash-w-Permission-denied-.patch
- Update to 2015.8.5
See https://docs.saltstack.com/en/latest/topics/releases/2015.8.5.html
Dropped patches (all upstream):
* 0003-List-products-consistently-across-all-SLES-systems.patch
* 0004-Add-missing-return-data-to-scheduled-jobs.patch
* 0005-Fix-RPM-issues-with-the-date-time-and-add-package-at.patch
* 0006-Bugfix-info_available-does-not-work-correctly-on-SLE.patch
Renamed patches:
* 0007-Check-if-byte-strings-are-properly-encoded-in-UTF-8.patch
-> 0003-Check-if-byte-strings-are-properly-encoded-in-UTF-8.patch
* 0008-Fix-pkg.latest-prevent-crash-on-multiple-package-ins.patch
-> 0004-Fix-pkg.latest-prevent-crash-on-multiple-package-ins.patch
* 0009-Fix-package-status-filtering-on-latest-version-and-i.patch
-> 0005-Fix-package-status-filtering-on-latest-version-and-i.patch
- Update to 2015.8.4
See https://docs.saltstack.com/en/latest/topics/releases/2015.8.4.html
- Fix latest version available comparison and implement epoch
support in Zypper module.
Add:
* 0009-Fix-package-status-filtering-on-latest-version-and-i.patch
- Update patch from opensuse to upstream version.
Update:
* 0008-Fix-pkg.latest-prevent-crash-on-multiple-package-ins.patch
- Fix dependencies to Salt subpackages requiring release along the
version.
- Fix pkg.latest crash.
- Fix pkg.latest SLS ID bug, when pkgs empty list is passed,
but SLS ID still treated as a package name.
Add:
* 0008-Fix-pkg.latest-prevent-crash-on-multiple-package-ins.patch
- Drop:
* -0004-zypper-check-package-header-content-for-valid-utf-8.patch
- Rename:
* -0004-zypper-check-package-header-content-for-valid-utf-8.patch
+0004-Add-missing-return-data-to-scheduled-jobs.patch
* -0005-Add-missing-return-data-to-scheduled-jobs.patch
+0004-Add-missing-return-data-to-scheduled-jobs.patch
* -0006-Fix-RPM-issues-with-the-date-time-and-add-package-at.patch
+0005-Fix-RPM-issues-with-the-date-time-and-add-package-at.patch
* -0007-Bugfix-info_available-does-not-work-correctly-on-SLE.patch
+0006-Bugfix-info_available-does-not-work-correctly-on-SLE.patch
- Add:
* 0007-Check-if-byte-strings-are-properly-encoded-in-UTF-8.patch
- Rename use-forking-daemon.patch to
0001-tserong-suse.com-We-don-t-have-python-systemd-so-not.patch
- Rename use-salt-user-for-master.patch to
0002-Run-salt-master-as-dedicated-salt-user.patch
- Rename 1efe484309a5c776974e723f3da0f5181f4bdb86.patch to
0003-List-products-consistently-across-all-SLES-systems.patch
- Rename zypper-utf-8.patch to
0004-zypper-check-package-header-content-for-valid-utf-8.patch
- Rename salt-2015.8-schedule-ret.patch to
0005-Add-missing-return-data-to-scheduled-jobs.patch
- Rename salt-2015.8-pkg-zypper-attr-filtering.patch to
0006-Fix-RPM-issues-with-the-date-time-and-add-package-at.patch
- Rename salt-2015.8-zypper-info.patch to
0007-Bugfix-info_available-does-not-work-correctly-on-SLE.patch
OBS-URL: https://build.opensuse.org/request/show/361294
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/salt?expand=0&rev=55
94 lines
2.7 KiB
Diff
94 lines
2.7 KiB
Diff
From c26d1b6987a06e972749a10af1c54befae14c6e6 Mon Sep 17 00:00:00 2001
|
|
From: Michael Calmer <mc@suse.de>
|
|
Date: Tue, 16 Feb 2016 13:48:50 +0100
|
|
Subject: [PATCH 13/22] pylint changes
|
|
|
|
---
|
|
salt/modules/zypper.py | 30 ++++++++++++++++--------------
|
|
1 file changed, 16 insertions(+), 14 deletions(-)
|
|
|
|
diff --git a/salt/modules/zypper.py b/salt/modules/zypper.py
|
|
index bd9c30a..7448f8b 100644
|
|
--- a/salt/modules/zypper.py
|
|
+++ b/salt/modules/zypper.py
|
|
@@ -2,7 +2,7 @@
|
|
'''
|
|
Package support for openSUSE via the zypper package manager
|
|
|
|
-:depends: - ``zypp`` Python module. Install with ``zypper install python-zypp``
|
|
+:depends: - ``rpm`` Python module. Install with ``zypper install rpm-python``
|
|
'''
|
|
|
|
# Import python libs
|
|
@@ -11,10 +11,10 @@ import copy
|
|
import logging
|
|
import re
|
|
import os
|
|
-import rpm
|
|
|
|
# Import 3rd-party libs
|
|
# pylint: disable=import-error,redefined-builtin,no-name-in-module
|
|
+import rpm
|
|
import salt.ext.six as six
|
|
from salt.ext.six.moves import configparser
|
|
from salt.ext.six.moves.urllib.parse import urlparse as _urlparse
|
|
@@ -289,7 +289,8 @@ def version(*names, **kwargs):
|
|
'''
|
|
return __salt__['pkg_resource.version'](*names, **kwargs) or {}
|
|
|
|
-def _stringToEVR(verstring):
|
|
+
|
|
+def _string_to_evr(verstring):
|
|
'''
|
|
Split the version string into epoch, version and release and
|
|
return this as tuple.
|
|
@@ -304,24 +305,25 @@ def _stringToEVR(verstring):
|
|
'''
|
|
if verstring in [None, '']:
|
|
return ('0', '', '')
|
|
- i = verstring.find(':')
|
|
- if i != -1:
|
|
+ idx_e = verstring.find(':')
|
|
+ if idx_e != -1:
|
|
try:
|
|
- epoch = str(long(verstring[:i]))
|
|
+ epoch = str(int(verstring[:idx_e]))
|
|
except ValueError:
|
|
# look, garbage in the epoch field, how fun, kill it
|
|
- epoch = '0' # this is our fallback, deal
|
|
+ epoch = '0' # this is our fallback, deal
|
|
else:
|
|
epoch = '0'
|
|
- j = verstring.find('-')
|
|
- if j != -1:
|
|
- version = verstring[i + 1:j]
|
|
- release = verstring[j + 1:]
|
|
+ idx_r = verstring.find('-')
|
|
+ if idx_r != -1:
|
|
+ version = verstring[idx_e + 1:idx_r]
|
|
+ release = verstring[idx_r + 1:]
|
|
else:
|
|
- version = verstring[i + 1:]
|
|
+ version = verstring[idx_e + 1:]
|
|
release = ''
|
|
return (epoch, version, release)
|
|
|
|
+
|
|
def version_cmp(ver1, ver2):
|
|
'''
|
|
.. versionadded:: 2015.5.4
|
|
@@ -338,8 +340,8 @@ def version_cmp(ver1, ver2):
|
|
'''
|
|
try:
|
|
cmp_result = rpm.labelCompare(
|
|
- _stringToEVR(ver1),
|
|
- _stringToEVR(ver2)
|
|
+ _string_to_evr(ver1),
|
|
+ _string_to_evr(ver2)
|
|
)
|
|
if cmp_result not in (-1, 0, 1):
|
|
raise Exception(
|
|
--
|
|
2.1.4
|
|
|