2686359b2c
- Update to Salt release version 3006.0 (jsc#PED-3139) * See release notes: https://docs.saltproject.io/en/latest/topics/releases/3006.0.html - Add python3-looseversion as new dependency for salt - Add python3-packaging as new dependency for salt - Drop conflictive patch dicarded from upstream - Fix SLS rendering error when Jinja macros are used - Fix version detection and avoid building and testing failures - Added: * fix-version-detection-and-avoid-building-and-testing.patch * make-sure-the-file-client-is-destroyed-upon-used.patch - Modified: * 3005.1-implement-zypper-removeptf-573.patch * activate-all-beacons-sources-config-pillar-grains.patch * add-custom-suse-capabilities-as-grains.patch * add-environment-variable-to-know-if-yum-is-invoked-f.patch * add-migrated-state-and-gpg-key-management-functions-.patch * add-publish_batch-to-clearfuncs-exposed-methods.patch * add-salt-ssh-support-with-venv-salt-minion-3004-493.patch * add-sleep-on-exception-handling-on-minion-connection.patch * add-standalone-configuration-file-for-enabling-packa.patch * add-support-for-gpgautoimport-539.patch * allow-vendor-change-option-with-zypper.patch * async-batch-implementation.patch * avoid-excessive-syslogging-by-watchdog-cronjob-58.patch * bsc-1176024-fix-file-directory-user-and-group-owners.patch * change-the-delimeters-to-prevent-possible-tracebacks.patch * control-the-collection-of-lvm-grains-via-config.patch * debian-info_installed-compatibility-50453.patch * dnfnotify-pkgset-plugin-implementation-3002.2-450.patch * do-not-load-pip-state-if-there-is-no-3rd-party-depen.patch * don-t-use-shell-sbin-nologin-in-requisites.patch * drop-serial-from-event.unpack-in-cli.batch_async.patch * early-feature-support-config.patch * enable-passing-a-unix_socket-for-mysql-returners-bsc.patch * enhance-openscap-module-add-xccdf_eval-call-386.patch * fix-bsc-1065792.patch * fix-for-suse-expanded-support-detection.patch * fix-issue-2068-test.patch * fix-missing-minion-returns-in-batch-mode-360.patch * fix-ownership-of-salt-thin-directory-when-using-the-.patch * fix-regression-with-depending-client.ssh-on-psutil-b.patch * fix-salt-ssh-opts-poisoning-bsc-1197637-3004-501.patch * fix-salt.utils.stringutils.to_str-calls-to-make-it-w.patch * fix-the-regression-for-yumnotify-plugin-456.patch * fix-traceback.print_exc-calls-for-test_pip_state-432.patch * fixes-for-python-3.10-502.patch * include-aliases-in-the-fqdns-grains.patch * info_installed-works-without-status-attr-now.patch * let-salt-ssh-use-platform-python-binary-in-rhel8-191.patch * make-aptpkg.list_repos-compatible-on-enabled-disable.patch * make-setup.py-script-to-not-require-setuptools-9.1.patch * pass-the-context-to-pillar-ext-modules.patch * prevent-affection-of-ssh.opts-with-lazyloader-bsc-11.patch * prevent-pkg-plugins-errors-on-missing-cookie-path-bs.patch * prevent-shell-injection-via-pre_flight_script_args-4.patch * read-repo-info-without-using-interpolation-bsc-11356.patch * restore-default-behaviour-of-pkg-list-return.patch * return-the-expected-powerpc-os-arch-bsc-1117995.patch * revert-fixing-a-use-case-when-multiple-inotify-beaco.patch * run-salt-api-as-user-salt-bsc-1064520.patch * run-salt-master-as-dedicated-salt-user.patch * save-log-to-logfile-with-docker.build.patch * skip-package-names-without-colon-bsc-1208691-578.patch * switch-firewalld-state-to-use-change_interface.patch * temporary-fix-extend-the-whitelist-of-allowed-comman.patch * update-target-fix-for-salt-ssh-to-process-targets-li.patch * use-adler32-algorithm-to-compute-string-checksums.patch * use-rlock-to-avoid-deadlocks-in-salt-ssh.patch * use-salt-bundle-in-dockermod.patch * x509-fixes-111.patch * zypperpkg-ignore-retcode-104-for-search-bsc-1176697-.patch - Removed: * add-amazon-ec2-detection-for-virtual-grains-bsc-1195.patch * add-support-for-name-pkgs-and-diff_attr-parameters-t.patch * align-amazon-ec2-nitro-grains-with-upstream-pr-bsc-1.patch * allow-entrypoint-compatibility-for-importlib-metadat.patch * clarify-pkg.installed-pkg_verify-documentation.patch * detect-module.run-syntax.patch * fix-salt.states.file.managed-for-follow_symlinks-tru.patch * fix-state.apply-in-test-mode-with-file-state-module-.patch * fix-test_ipc-unit-tests.patch * fixes-pkg.version_cmp-on-openeuler-systems-and-a-few.patch * fopen-workaround-bad-buffering-for-binary-mode-563.patch * ignore-erros-on-reading-license-files-with-dpkg_lowp.patch * ignore-extend-declarations-from-excluded-sls-files.patch * ignore-non-utf8-characters-while-reading-files-with-.patch * include-stdout-in-error-message-for-zypperpkg-559.patch * make-pass-renderer-configurable-other-fixes-532.patch * make-sure-saltcacheloader-use-correct-fileclient-519.patch * normalize-package-names-once-with-pkg.installed-remo.patch * retry-if-rpm-lock-is-temporarily-unavailable-547.patch * set-default-target-for-pip-from-venv_pip_target-envi.patch * state.apply-don-t-check-for-cached-pillar-errors.patch * state.orchestrate_single-does-not-pass-pillar-none-4.patch OBS-URL: https://build.opensuse.org/request/show/1084999 OBS-URL: https://build.opensuse.org/package/show/systemsmanagement:saltstack/salt?expand=0&rev=210
113 lines
4.2 KiB
Diff
113 lines
4.2 KiB
Diff
From 2ca37fe7d2a03ad86ed738f2636fe240b9f4467e Mon Sep 17 00:00:00 2001
|
|
From: Victor Zhestkov <35733135+vzhestkov@users.noreply.github.com>
|
|
Date: Tue, 6 Oct 2020 12:36:41 +0300
|
|
Subject: [PATCH] bsc#1176024: Fix file/directory user and group
|
|
ownership containing UTF-8 characters (#275)
|
|
|
|
* Fix check_perm typos of file module
|
|
|
|
* Fix UTF8 support for user/group ownership operations with file module and state
|
|
|
|
* Fix UTF8 support for user/group ownership operations with file module and state
|
|
|
|
Co-authored-by: Victor Zhestkov <vzhestkov@vz-thinkpad.vzhestkov.net>
|
|
---
|
|
salt/modules/file.py | 20 ++++++++++----------
|
|
salt/states/file.py | 12 ++++++++++--
|
|
2 files changed, 20 insertions(+), 12 deletions(-)
|
|
|
|
diff --git a/salt/modules/file.py b/salt/modules/file.py
|
|
index 69d7992f5a..4612d65511 100644
|
|
--- a/salt/modules/file.py
|
|
+++ b/salt/modules/file.py
|
|
@@ -245,7 +245,7 @@ def group_to_gid(group):
|
|
try:
|
|
if isinstance(group, int):
|
|
return group
|
|
- return grp.getgrnam(group).gr_gid
|
|
+ return grp.getgrnam(salt.utils.stringutils.to_str(group)).gr_gid
|
|
except KeyError:
|
|
return ""
|
|
|
|
@@ -336,7 +336,7 @@ def user_to_uid(user):
|
|
try:
|
|
if isinstance(user, int):
|
|
return user
|
|
- return pwd.getpwnam(user).pw_uid
|
|
+ return pwd.getpwnam(salt.utils.stringutils.to_str(user)).pw_uid
|
|
except KeyError:
|
|
return ""
|
|
|
|
@@ -5133,8 +5133,8 @@ def check_perms(
|
|
salt.utils.platform.is_windows() and not user_to_uid(user) == cur["uid"]
|
|
) or (
|
|
not salt.utils.platform.is_windows()
|
|
- and not user == cur["user"]
|
|
- and not user == cur["uid"]
|
|
+ and not salt.utils.stringutils.to_str(user) == cur["user"]
|
|
+ and not salt.utils.stringutils.to_str(user) == cur["uid"]
|
|
):
|
|
perms["cuser"] = user
|
|
|
|
@@ -5143,8 +5143,8 @@ def check_perms(
|
|
salt.utils.platform.is_windows() and not group_to_gid(group) == cur["gid"]
|
|
) or (
|
|
not salt.utils.platform.is_windows()
|
|
- and not group == cur["group"]
|
|
- and not group == cur["gid"]
|
|
+ and not salt.utils.stringutils.to_str(group) == cur["group"]
|
|
+ and not salt.utils.stringutils.to_str(group) == cur["gid"]
|
|
):
|
|
perms["cgroup"] = group
|
|
|
|
@@ -5188,8 +5188,8 @@ def check_perms(
|
|
salt.utils.platform.is_windows() and not user_to_uid(user) == post["uid"]
|
|
) or (
|
|
not salt.utils.platform.is_windows()
|
|
- and not user == post["user"]
|
|
- and not user == post["uid"]
|
|
+ and not salt.utils.stringutils.to_str(user) == post["user"]
|
|
+ and not salt.utils.stringutils.to_str(user) == post["uid"]
|
|
):
|
|
if __opts__["test"] is True:
|
|
ret["changes"]["user"] = user
|
|
@@ -5204,8 +5204,8 @@ def check_perms(
|
|
salt.utils.platform.is_windows() and not group_to_gid(group) == post["gid"]
|
|
) or (
|
|
not salt.utils.platform.is_windows()
|
|
- and not group == post["group"]
|
|
- and not group == post["gid"]
|
|
+ and not salt.utils.stringutils.to_str(group) == post["group"]
|
|
+ and not salt.utils.stringutils.to_str(group) == post["gid"]
|
|
):
|
|
if __opts__["test"] is True:
|
|
ret["changes"]["group"] = group
|
|
diff --git a/salt/states/file.py b/salt/states/file.py
|
|
index 9f32151b8b..024e5e34ce 100644
|
|
--- a/salt/states/file.py
|
|
+++ b/salt/states/file.py
|
|
@@ -864,9 +864,17 @@ def _check_dir_meta(name, user, group, mode, follow_symlinks=False):
|
|
if not stats:
|
|
changes["directory"] = "new"
|
|
return changes
|
|
- if user is not None and user != stats["user"] and user != stats.get("uid"):
|
|
+ if (
|
|
+ user is not None
|
|
+ and salt.utils.stringutils.to_str(user) != stats["user"]
|
|
+ and user != stats.get("uid")
|
|
+ ):
|
|
changes["user"] = user
|
|
- if group is not None and group != stats["group"] and group != stats.get("gid"):
|
|
+ if (
|
|
+ group is not None
|
|
+ and salt.utils.stringutils.to_str(group) != stats["group"]
|
|
+ and group != stats.get("gid")
|
|
+ ):
|
|
changes["group"] = group
|
|
# Normalize the dir mode
|
|
smode = salt.utils.files.normalize_mode(stats["mode"])
|
|
--
|
|
2.39.2
|
|
|
|
|